2009-09-10 23:59:03

by David Daney

[permalink] [raw]
Subject: [PATCH 06/10] parisc: Convert BUG() to use unreachable()

Use the new unreachable() macro instead of for(;;);

Signed-off-by: David Daney <[email protected]>
CC: Kyle McMartin <[email protected]>
CC: Helge Deller <[email protected]>
CC: [email protected]
---
arch/parisc/include/asm/bug.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/parisc/include/asm/bug.h b/arch/parisc/include/asm/bug.h
index 8cfc553..75e46c5 100644
--- a/arch/parisc/include/asm/bug.h
+++ b/arch/parisc/include/asm/bug.h
@@ -32,14 +32,14 @@
"\t.popsection" \
: : "i" (__FILE__), "i" (__LINE__), \
"i" (0), "i" (sizeof(struct bug_entry)) ); \
- for(;;) ; \
+ unreachable(); \
} while(0)

#else
#define BUG() \
do { \
asm volatile(PARISC_BUG_BREAK_ASM : : ); \
- for(;;) ; \
+ unreachable(); \
} while(0)
#endif

--
1.6.2.5


2009-09-28 03:20:22

by Kyle McMartin

[permalink] [raw]
Subject: Re: [PATCH 06/10] parisc: Convert BUG() to use unreachable()

On Thu, Sep 10, 2009 at 04:56:47PM -0700, David Daney wrote:
> Use the new unreachable() macro instead of for(;;);
>
> Signed-off-by: David Daney <[email protected]>
> CC: Kyle McMartin <[email protected]>
> CC: Helge Deller <[email protected]>
> CC: [email protected]

Since the dependent part of this patch seems to have missed the merge
window, I guess we'll sit on this until next round?

--Kyle