2010-04-09 03:15:36

by Kamezawa Hiroyuki

[permalink] [raw]
Subject: [PATCH] fix cgroup procs documentation

2.6.33's Documentation has the same wrong information. So, I CC'ed to stable.
If people believe this information, they'll usr cgroup.procs file and will
see cgroup doesn'w work as expected.
The patch itself is against -mm.

==
Writing to cgroup.procs is not supported now.

Signed-off-by: KAMEZAWA Hiroyuki <[email protected]>
---
Documentation/cgroups/cgroups.txt | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

Index: mmotm-temp/Documentation/cgroups/cgroups.txt
===================================================================
--- mmotm-temp.orig/Documentation/cgroups/cgroups.txt
+++ mmotm-temp/Documentation/cgroups/cgroups.txt
@@ -235,8 +235,7 @@ containing the following files describin
- cgroup.procs: list of tgids in the cgroup. This list is not
guaranteed to be sorted or free of duplicate tgids, and userspace
should sort/uniquify the list if this property is required.
- Writing a tgid into this file moves all threads with that tgid into
- this cgroup.
+ This is a read-only file, now.
- notify_on_release flag: run the release agent on exit?
- release_agent: the path to use for release notifications (this file
exists in the top cgroup only)


2010-04-09 03:20:45

by Li Zefan

[permalink] [raw]
Subject: Re: [PATCH] fix cgroup procs documentation

KAMEZAWA Hiroyuki wrote:
> 2.6.33's Documentation has the same wrong information. So, I CC'ed to stable.
> If people believe this information, they'll usr cgroup.procs file and will
> see cgroup doesn'w work as expected.
> The patch itself is against -mm.
>
> ==
> Writing to cgroup.procs is not supported now.
>
> Signed-off-by: KAMEZAWA Hiroyuki <[email protected]>
> ---
> Documentation/cgroups/cgroups.txt | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Index: mmotm-temp/Documentation/cgroups/cgroups.txt
> ===================================================================
> --- mmotm-temp.orig/Documentation/cgroups/cgroups.txt
> +++ mmotm-temp/Documentation/cgroups/cgroups.txt
> @@ -235,8 +235,7 @@ containing the following files describin
> - cgroup.procs: list of tgids in the cgroup. This list is not
> guaranteed to be sorted or free of duplicate tgids, and userspace
> should sort/uniquify the list if this property is required.
> - Writing a tgid into this file moves all threads with that tgid into
> - this cgroup.
> + This is a read-only file, now.

I think the better wording is "for now". :)

> - notify_on_release flag: run the release agent on exit?
> - release_agent: the path to use for release notifications (this file
> exists in the top cgroup only)
>

2010-04-09 03:23:55

by Kamezawa Hiroyuki

[permalink] [raw]
Subject: Re: [PATCH] fix cgroup procs documentation

On Fri, 09 Apr 2010 11:22:00 +0800
Li Zefan <[email protected]> wrote:

> KAMEZAWA Hiroyuki wrote:
> > 2.6.33's Documentation has the same wrong information. So, I CC'ed to stable.
> > If people believe this information, they'll usr cgroup.procs file and will
> > see cgroup doesn'w work as expected.
> > The patch itself is against -mm.
> >
> > ==
> > Writing to cgroup.procs is not supported now.
> >
> > Signed-off-by: KAMEZAWA Hiroyuki <[email protected]>
> > ---
> > Documentation/cgroups/cgroups.txt | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > Index: mmotm-temp/Documentation/cgroups/cgroups.txt
> > ===================================================================
> > --- mmotm-temp.orig/Documentation/cgroups/cgroups.txt
> > +++ mmotm-temp/Documentation/cgroups/cgroups.txt
> > @@ -235,8 +235,7 @@ containing the following files describin
> > - cgroup.procs: list of tgids in the cgroup. This list is not
> > guaranteed to be sorted or free of duplicate tgids, and userspace
> > should sort/uniquify the list if this property is required.
> > - Writing a tgid into this file moves all threads with that tgid into
> > - this cgroup.
> > + This is a read-only file, now.
>
> I think the better wording is "for now". :)
>
ok. BTW, does anyone work on this ?
==

Writing to cgroup.procs is not supported now.

Signed-off-by: KAMEZAWA Hiroyuki <[email protected]>
---
Documentation/cgroups/cgroups.txt | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

Index: mmotm-temp/Documentation/cgroups/cgroups.txt
===================================================================
--- mmotm-temp.orig/Documentation/cgroups/cgroups.txt
+++ mmotm-temp/Documentation/cgroups/cgroups.txt
@@ -235,8 +235,7 @@ containing the following files describin
- cgroup.procs: list of tgids in the cgroup. This list is not
guaranteed to be sorted or free of duplicate tgids, and userspace
should sort/uniquify the list if this property is required.
- Writing a tgid into this file moves all threads with that tgid into
- this cgroup.
+ This is a read-only file, for now.
- notify_on_release flag: run the release agent on exit?
- release_agent: the path to use for release notifications (this file
exists in the top cgroup only)

2010-04-09 03:30:46

by Li Zefan

[permalink] [raw]
Subject: Re: [PATCH] fix cgroup procs documentation

Cc: Ben Blum

KAMEZAWA Hiroyuki wrote:
> On Fri, 09 Apr 2010 11:22:00 +0800
> Li Zefan <[email protected]> wrote:
>
>> KAMEZAWA Hiroyuki wrote:
>>> 2.6.33's Documentation has the same wrong information. So, I CC'ed to stable.
>>> If people believe this information, they'll usr cgroup.procs file and will
>>> see cgroup doesn'w work as expected.
>>> The patch itself is against -mm.
>>>
>>> ==
>>> Writing to cgroup.procs is not supported now.
>>>
>>> Signed-off-by: KAMEZAWA Hiroyuki <[email protected]>
>>> ---
>>> Documentation/cgroups/cgroups.txt | 3 +--
>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> Index: mmotm-temp/Documentation/cgroups/cgroups.txt
>>> ===================================================================
>>> --- mmotm-temp.orig/Documentation/cgroups/cgroups.txt
>>> +++ mmotm-temp/Documentation/cgroups/cgroups.txt
>>> @@ -235,8 +235,7 @@ containing the following files describin
>>> - cgroup.procs: list of tgids in the cgroup. This list is not
>>> guaranteed to be sorted or free of duplicate tgids, and userspace
>>> should sort/uniquify the list if this property is required.
>>> - Writing a tgid into this file moves all threads with that tgid into
>>> - this cgroup.
>>> + This is a read-only file, now.
>> I think the better wording is "for now". :)
>>
> ok. BTW, does anyone work on this ?

It was Ben Blum, don't know if he's still working on it.

> ==
>
> Writing to cgroup.procs is not supported now.
>
> Signed-off-by: KAMEZAWA Hiroyuki <[email protected]>

Acked-by: Li Zefan <[email protected]>

> ---
> Documentation/cgroups/cgroups.txt | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Index: mmotm-temp/Documentation/cgroups/cgroups.txt
> ===================================================================
> --- mmotm-temp.orig/Documentation/cgroups/cgroups.txt
> +++ mmotm-temp/Documentation/cgroups/cgroups.txt
> @@ -235,8 +235,7 @@ containing the following files describin
> - cgroup.procs: list of tgids in the cgroup. This list is not
> guaranteed to be sorted or free of duplicate tgids, and userspace
> should sort/uniquify the list if this property is required.
> - Writing a tgid into this file moves all threads with that tgid into
> - this cgroup.
> + This is a read-only file, for now.
> - notify_on_release flag: run the release agent on exit?
> - release_agent: the path to use for release notifications (this file
> exists in the top cgroup only)
>
>
>

2010-04-12 10:51:18

by Ben Blum

[permalink] [raw]
Subject: Re: [PATCH] fix cgroup procs documentation

On Fri, Apr 09, 2010 at 11:31:54AM +0800, Li Zefan wrote:
> Cc: Ben Blum
>
> KAMEZAWA Hiroyuki wrote:
> > On Fri, 09 Apr 2010 11:22:00 +0800
> > Li Zefan <[email protected]> wrote:
> >
> >> KAMEZAWA Hiroyuki wrote:
> >>> 2.6.33's Documentation has the same wrong information. So, I CC'ed to stable.
> >>> If people believe this information, they'll usr cgroup.procs file and will
> >>> see cgroup doesn'w work as expected.
> >>> The patch itself is against -mm.
> >>>
> >>> ==
> >>> Writing to cgroup.procs is not supported now.
> >>>
> >>> Signed-off-by: KAMEZAWA Hiroyuki <[email protected]>
> >>> ---
> >>> Documentation/cgroups/cgroups.txt | 3 +--
> >>> 1 file changed, 1 insertion(+), 2 deletions(-)
> >>>
> >>> Index: mmotm-temp/Documentation/cgroups/cgroups.txt
> >>> ===================================================================
> >>> --- mmotm-temp.orig/Documentation/cgroups/cgroups.txt
> >>> +++ mmotm-temp/Documentation/cgroups/cgroups.txt
> >>> @@ -235,8 +235,7 @@ containing the following files describin
> >>> - cgroup.procs: list of tgids in the cgroup. This list is not
> >>> guaranteed to be sorted or free of duplicate tgids, and userspace
> >>> should sort/uniquify the list if this property is required.
> >>> - Writing a tgid into this file moves all threads with that tgid into
> >>> - this cgroup.
> >>> + This is a read-only file, now.
> >> I think the better wording is "for now". :)
> >>
> > ok. BTW, does anyone work on this ?
>
> It was Ben Blum, don't know if he's still working on it.

Aye. Oleg suggested a redesign of the last patch (putting the lock in
signal_struct instead of sighand_struct), but I haven't got time to work
on them now. Expect a revision in maybe two months...

>
> > ==
> >
> > Writing to cgroup.procs is not supported now.
> >
> > Signed-off-by: KAMEZAWA Hiroyuki <[email protected]>
>
> Acked-by: Li Zefan <[email protected]>
>
> > ---
> > Documentation/cgroups/cgroups.txt | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > Index: mmotm-temp/Documentation/cgroups/cgroups.txt
> > ===================================================================
> > --- mmotm-temp.orig/Documentation/cgroups/cgroups.txt
> > +++ mmotm-temp/Documentation/cgroups/cgroups.txt
> > @@ -235,8 +235,7 @@ containing the following files describin
> > - cgroup.procs: list of tgids in the cgroup. This list is not
> > guaranteed to be sorted or free of duplicate tgids, and userspace
> > should sort/uniquify the list if this property is required.
> > - Writing a tgid into this file moves all threads with that tgid into
> > - this cgroup.
> > + This is a read-only file, for now.
> > - notify_on_release flag: run the release agent on exit?
> > - release_agent: the path to use for release notifications (this file
> > exists in the top cgroup only)
> >
> >
> >
>