2010-08-12 09:54:42

by Jindrich Makovicka

[permalink] [raw]
Subject: [PATCH] forcedeth: reconfigure multicast packet filter only when needed

Currently, the forcedeth driver reconfigures the packet filter every
time a multicast stream is (un-)subscribed. As the receiving has to be
stopped and started in this case, any multicast subscription can cause
packet loss, allowing userspace applications to disrupt incoming
traffic.

With the following patch, nv_set_multicast first checks the cached
state of the packet filter, and skips the reconfiguration if the state
does not change. With the default settings, this can reduce some
useless reconfiguration attempts. When switched to promiscuous mode,
all reconfigurations are skipped with the patch, which can be used to
mitigate packet loss problems when receiving and re-subscribing many
multicasts simultaneously on a single machine.

Signed-off-by: Jindrich Makovicka <[email protected]>

--
Jindrich Makovicka


Attachments:
(No filename) (824.00 B)
forcedeth.c.diff (2.16 kB)
Download all attachments