2010-08-18 19:21:59

by Mike Frysinger

[permalink] [raw]
Subject: nommu vm_get_page_prot and framebuffer drivers in 2.6.36-rc1

the recent commit c07fbfd17e614a76b194f371c5331e21e6cffb54 added a
call to vm_get_page_prot() in drivers/video/fbmem.c. but this
function doesnt exist for nommu. so obviously we get:
ERROR: "vm_get_page_prot" [drivers/video/fb.ko] undefined!

looking a bit through mm/, i guess we should stub this out to 0 ?
#define vm_page_prot(x) 0
-mike


2010-08-19 15:03:46

by Konrad Rzeszutek Wilk

[permalink] [raw]
Subject: Re: nommu vm_get_page_prot and framebuffer drivers in 2.6.36-rc1

On Wed, Aug 18, 2010 at 03:21:35PM -0400, Mike Frysinger wrote:
> the recent commit c07fbfd17e614a76b194f371c5331e21e6cffb54 added a

Next time please do write to the folks that are on the Signed-off-by
list on the patch.

> call to vm_get_page_prot() in drivers/video/fbmem.c. but this
> function doesnt exist for nommu. so obviously we get:
> ERROR: "vm_get_page_prot" [drivers/video/fb.ko] undefined!

Duh!
>
> looking a bit through mm/, i guess we should stub this out to 0 ?

Yes. Could you create a patch for this, please?

> #define vm_page_prot(x) 0
> -mike
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/