2011-02-01 10:41:41

by Tejun Heo

Subject: Re: [PATCH UPDATED 08/32] drm/nouveau: use system_wq instead of dev_priv->wq

On Wed, Jan 26, 2011 at 05:49:18PM +0100, Tejun Heo wrote:
> With cmwq, there's no reason for nouveau to use a dedicated workqueue.
> Drop dev_priv->wq and use system_wq instead. Each work item is sync
> flushed when the containing structure is unregistered/destroyed.
>
> Note that this change also makes sure that nv50_gpio_handler is not
> freed while the contained work item is still running.
>
> Signed-off-by: Tejun Heo <[email protected]>
> Cc: David Airlie <[email protected]>
> Cc: [email protected]

Ping. Can you please put this through the drm tree?

Thank you.

--
tejun

2011-02-04 01:54:08

by Ben Skeggs

Subject: Re: [PATCH UPDATED 08/32] drm/nouveau: use system_wq instead of dev_priv->wq

On Tue, 2011-02-01 at 11:41 +0100, Tejun Heo wrote:
> On Wed, Jan 26, 2011 at 05:49:18PM +0100, Tejun Heo wrote:
> > With cmwq, there's no reason for nouveau to use a dedicated workqueue.
> > Drop dev_priv->wq and use system_wq instead. Each work item is sync
> > flushed when the containing structure is unregistered/destroyed.
> >
> > Note that this change also makes sure that nv50_gpio_handler is not
> > freed while the contained work item is still running.
> >
> > Signed-off-by: Tejun Heo <[email protected]>
> > Cc: David Airlie <[email protected]>
> > Cc: [email protected]
>
> Ping. Can you please put this through the drm tree?
Hey Tejun,

Thanks for this again. I've just made some changes to the nv50 display
bottom half handling that these will conflict with, they'll hit the
nouveau tree next week.

I'll push the still-relevant bits of your nouveau patch through the
nouveau tree for the 2.6.39-rc1 merge window. That ok?

Thanks,
Ben.

>
> Thank you.
>

2011-02-04 11:04:02

by Tejun Heo

Subject: Re: [PATCH UPDATED 08/32] drm/nouveau: use system_wq instead of dev_priv->wq

Hello,

On Fri, Feb 04, 2011 at 11:53:25AM +1000, Ben Skeggs wrote:
> Thanks for this again. I've just made some changes to the nv50 display
> bottom half handling that these will conflict with, they'll hit the
> nouveau tree next week.

Eh, so it doesn't apply again? :-)

> I'll push the still-relevant bits of your nouveau patch through the
> nouveau tree for the 2.6.39-rc1 merge window. That ok?

Yeah, sure, but if you tell me against which tree I should generate
patch, I can also just redo the patch.

Thanks.

--
tejun