2011-03-18 22:00:13

by David Miller

[permalink] [raw]
Subject: [PATCH] of_mmc_spi: Need to include irq.h and of_irq.h


Since these are the headers that provide irq_of_parse_and_map()
and NO_IRQ.

Signed-off-by: David S. Miller <[email protected]>

diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_mmc_spi.c
index 5530def..e2aecb7 100644
--- a/drivers/mmc/host/of_mmc_spi.c
+++ b/drivers/mmc/host/of_mmc_spi.c
@@ -15,9 +15,11 @@
#include <linux/module.h>
#include <linux/device.h>
#include <linux/slab.h>
+#include <linux/irq.h>
#include <linux/gpio.h>
#include <linux/of.h>
#include <linux/of_gpio.h>
+#include <linux/of_irq.h>
#include <linux/spi/spi.h>
#include <linux/spi/mmc_spi.h>
#include <linux/mmc/core.h>


2011-03-24 03:41:59

by Grant Likely

[permalink] [raw]
Subject: Re: [PATCH] of_mmc_spi: Need to include irq.h and of_irq.h

On Fri, Mar 18, 2011 at 03:00:23PM -0700, David Miller wrote:
>
> Since these are the headers that provide irq_of_parse_and_map()
> and NO_IRQ.
>
> Signed-off-by: David S. Miller <[email protected]>

Acked-by: Grant Likely <[email protected]>

Chris, let me know if you need me to take this via my tree.

g.

>
> diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_mmc_spi.c
> index 5530def..e2aecb7 100644
> --- a/drivers/mmc/host/of_mmc_spi.c
> +++ b/drivers/mmc/host/of_mmc_spi.c
> @@ -15,9 +15,11 @@
> #include <linux/module.h>
> #include <linux/device.h>
> #include <linux/slab.h>
> +#include <linux/irq.h>
> #include <linux/gpio.h>
> #include <linux/of.h>
> #include <linux/of_gpio.h>
> +#include <linux/of_irq.h>
> #include <linux/spi/spi.h>
> #include <linux/spi/mmc_spi.h>
> #include <linux/mmc/core.h>

2011-03-24 22:59:10

by Chris Ball

[permalink] [raw]
Subject: Re: [PATCH] of_mmc_spi: Need to include irq.h and of_irq.h

Hi,

On Fri, Mar 18 2011, David Miller wrote:
> Since these are the headers that provide irq_of_parse_and_map()
> and NO_IRQ.
>
> Signed-off-by: David S. Miller <[email protected]>
>
> diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_mmc_spi.c
> index 5530def..e2aecb7 100644
> --- a/drivers/mmc/host/of_mmc_spi.c
> +++ b/drivers/mmc/host/of_mmc_spi.c
> @@ -15,9 +15,11 @@
> #include <linux/module.h>
> #include <linux/device.h>
> #include <linux/slab.h>
> +#include <linux/irq.h>
> #include <linux/gpio.h>
> #include <linux/of.h>
> #include <linux/of_gpio.h>
> +#include <linux/of_irq.h>
> #include <linux/spi/spi.h>
> #include <linux/spi/mmc_spi.h>
> #include <linux/mmc/core.h>

Pushed to mmc-next for .39-rc2 with Grant's ACK, thanks.

- Chris.
--
Chris Ball <[email protected]> <http://printf.net/>
One Laptop Per Child