2011-03-29 16:37:06

by Justin P. Mattock

[permalink] [raw]
Subject: [PATCH]arch:Kconfig.locks Remove unused config option.

using a cleanup script I found this, could be real/fake not sure
I grepped the whole kernel and only found this. If/when you have
time let me know..

Signed-off-by: Justin P. Mattock <[email protected]>

---
arch/Kconfig | 3 ---
kernel/Kconfig.locks | 2 +-
2 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/arch/Kconfig b/arch/Kconfig
index f78c2be..8d24bac 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -144,9 +144,6 @@ config HAVE_CLK
config HAVE_DMA_API_DEBUG
bool

-config HAVE_DEFAULT_NO_SPIN_MUTEXES
- bool
-
config HAVE_HW_BREAKPOINT
bool
depends on PERF_EVENTS
diff --git a/kernel/Kconfig.locks b/kernel/Kconfig.locks
index 88c92fb..5e62baf 100644
--- a/kernel/Kconfig.locks
+++ b/kernel/Kconfig.locks
@@ -199,4 +199,4 @@ config INLINE_WRITE_UNLOCK_IRQRESTORE
def_bool !DEBUG_SPINLOCK && ARCH_INLINE_WRITE_UNLOCK_IRQRESTORE

config MUTEX_SPIN_ON_OWNER
- def_bool SMP && !DEBUG_MUTEXES && !HAVE_DEFAULT_NO_SPIN_MUTEXES
+ def_bool SMP && !DEBUG_MUTEXES
--
1.7.4.1


2011-03-29 17:53:11

by Steven Rostedt

[permalink] [raw]
Subject: Re: [PATCH]arch:Kconfig.locks Remove unused config option.

On Tue, Mar 29, 2011 at 09:36:51AM -0700, Justin P. Mattock wrote:
> using a cleanup script I found this, could be real/fake not sure
> I grepped the whole kernel and only found this. If/when you have
> time let me know..

This was added by: 36cd3c9f925b9307236505ae7ad1ad7ac4d4357c
mutex: have non-spinning mutexes on s390 by default

and removed by: fa188ae1657d6edc7963d524ce9a0650fe725242
[S390] mutex: enable spinning mutex on s390

So I think you are safe in removing it.

Thanks!

>
> Signed-off-by: Justin P. Mattock <[email protected]>

Acked-by: Steven Rostedt <[email protected]>

-- Steve

>
> ---
> arch/Kconfig | 3 ---
> kernel/Kconfig.locks | 2 +-
> 2 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/arch/Kconfig b/arch/Kconfig
> index f78c2be..8d24bac 100644
> --- a/arch/Kconfig
> +++ b/arch/Kconfig
> @@ -144,9 +144,6 @@ config HAVE_CLK
> config HAVE_DMA_API_DEBUG
> bool
>
> -config HAVE_DEFAULT_NO_SPIN_MUTEXES
> - bool
> -
> config HAVE_HW_BREAKPOINT
> bool
> depends on PERF_EVENTS
> diff --git a/kernel/Kconfig.locks b/kernel/Kconfig.locks
> index 88c92fb..5e62baf 100644
> --- a/kernel/Kconfig.locks
> +++ b/kernel/Kconfig.locks
> @@ -199,4 +199,4 @@ config INLINE_WRITE_UNLOCK_IRQRESTORE
> def_bool !DEBUG_SPINLOCK && ARCH_INLINE_WRITE_UNLOCK_IRQRESTORE
>
> config MUTEX_SPIN_ON_OWNER
> - def_bool SMP && !DEBUG_MUTEXES && !HAVE_DEFAULT_NO_SPIN_MUTEXES
> + def_bool SMP && !DEBUG_MUTEXES
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

2011-03-29 18:06:41

by Justin P. Mattock

[permalink] [raw]
Subject: Re: [PATCH]arch:Kconfig.locks Remove unused config option.

On 03/29/2011 10:53 AM, Steven Rostedt wrote:
> On Tue, Mar 29, 2011 at 09:36:51AM -0700, Justin P. Mattock wrote:
>> using a cleanup script I found this, could be real/fake not sure
>> I grepped the whole kernel and only found this. If/when you have
>> time let me know..
>
> This was added by: 36cd3c9f925b9307236505ae7ad1ad7ac4d4357c
> mutex: have non-spinning mutexes on s390 by default
>
> and removed by: fa188ae1657d6edc7963d524ce9a0650fe725242
> [S390] mutex: enable spinning mutex on s390
>
> So I think you are safe in removing it.
>
> Thanks!
>
>>
>> Signed-off-by: Justin P. Mattock<[email protected]>
>
> Acked-by: Steven Rostedt<[email protected]>
>
> -- Steve
>

o.k... a bit confusing with some of these, but good learning!!

>>
>> ---
>> arch/Kconfig | 3 ---
>> kernel/Kconfig.locks | 2 +-
>> 2 files changed, 1 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/Kconfig b/arch/Kconfig
>> index f78c2be..8d24bac 100644
>> --- a/arch/Kconfig
>> +++ b/arch/Kconfig
>> @@ -144,9 +144,6 @@ config HAVE_CLK
>> config HAVE_DMA_API_DEBUG
>> bool
>>
>> -config HAVE_DEFAULT_NO_SPIN_MUTEXES
>> - bool
>> -
>> config HAVE_HW_BREAKPOINT
>> bool
>> depends on PERF_EVENTS
>> diff --git a/kernel/Kconfig.locks b/kernel/Kconfig.locks
>> index 88c92fb..5e62baf 100644
>> --- a/kernel/Kconfig.locks
>> +++ b/kernel/Kconfig.locks
>> @@ -199,4 +199,4 @@ config INLINE_WRITE_UNLOCK_IRQRESTORE
>> def_bool !DEBUG_SPINLOCK&& ARCH_INLINE_WRITE_UNLOCK_IRQRESTORE
>>
>> config MUTEX_SPIN_ON_OWNER
>> - def_bool SMP&& !DEBUG_MUTEXES&& !HAVE_DEFAULT_NO_SPIN_MUTEXES
>> + def_bool SMP&& !DEBUG_MUTEXES
>> --
>> 1.7.4.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to [email protected]
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>

2011-03-30 06:23:03

by Heiko Carstens

[permalink] [raw]
Subject: Re: [PATCH]arch:Kconfig.locks Remove unused config option.

On Tue, Mar 29, 2011 at 01:53:02PM -0400, Steven Rostedt wrote:
> On Tue, Mar 29, 2011 at 09:36:51AM -0700, Justin P. Mattock wrote:
> > using a cleanup script I found this, could be real/fake not sure
> > I grepped the whole kernel and only found this. If/when you have
> > time let me know..
>
> This was added by: 36cd3c9f925b9307236505ae7ad1ad7ac4d4357c
> mutex: have non-spinning mutexes on s390 by default
>
> and removed by: fa188ae1657d6edc7963d524ce9a0650fe725242
> [S390] mutex: enable spinning mutex on s390
>
> So I think you are safe in removing it.

Yes, that's just a leftover.

>
> >
> > Signed-off-by: Justin P. Mattock <[email protected]>
>
> Acked-by: Steven Rostedt <[email protected]>

Acked-by: Heiko Carstens <[email protected]>

2011-03-30 15:52:20

by Justin P. Mattock

[permalink] [raw]
Subject: Re: [PATCH]arch:Kconfig.locks Remove unused config option.

On 03/29/2011 11:22 PM, Heiko Carstens wrote:
> On Tue, Mar 29, 2011 at 01:53:02PM -0400, Steven Rostedt wrote:
>> On Tue, Mar 29, 2011 at 09:36:51AM -0700, Justin P. Mattock wrote:
>>> using a cleanup script I found this, could be real/fake not sure
>>> I grepped the whole kernel and only found this. If/when you have
>>> time let me know..
>>
>> This was added by: 36cd3c9f925b9307236505ae7ad1ad7ac4d4357c
>> mutex: have non-spinning mutexes on s390 by default
>>
>> and removed by: fa188ae1657d6edc7963d524ce9a0650fe725242
>> [S390] mutex: enable spinning mutex on s390
>>
>> So I think you are safe in removing it.
>
> Yes, that's just a leftover.
>

alright.. well I do see some others wouldn't mind give those a try as well.

>>
>>>
>>> Signed-off-by: Justin P. Mattock<[email protected]>
>>
>> Acked-by: Steven Rostedt<[email protected]>
>
> Acked-by: Heiko Carstens<[email protected]>
>

2011-04-10 15:10:00

by Jiri Kosina

[permalink] [raw]
Subject: Re: [PATCH]arch:Kconfig.locks Remove unused config option.

On Wed, 30 Mar 2011, Heiko Carstens wrote:

> > > using a cleanup script I found this, could be real/fake not sure
> > > I grepped the whole kernel and only found this. If/when you have
> > > time let me know..
> >
> > This was added by: 36cd3c9f925b9307236505ae7ad1ad7ac4d4357c
> > mutex: have non-spinning mutexes on s390 by default
> >
> > and removed by: fa188ae1657d6edc7963d524ce9a0650fe725242
> > [S390] mutex: enable spinning mutex on s390
> >
> > So I think you are safe in removing it.
>
> Yes, that's just a leftover.
>
> > > Signed-off-by: Justin P. Mattock <[email protected]>
> >
> > Acked-by: Steven Rostedt <[email protected]>
>
> Acked-by: Heiko Carstens <[email protected]>

Applied, thanks everybody.

--
Jiri Kosina
SUSE Labs, Novell Inc.