LinuxLists.cc - linux-next: build warning from Linus' tree

2011-06-03 01:10:53

Subject: linux-next: build warning from Linus' tree

Hi all,

With Linus' tree, today's linux-next build (x86_64 allmodconfig) produced
this warning:

fs/btrfs/delayed-inode.c: In function 'btrfs_batch_insert_items':
fs/btrfs/delayed-inode.c:670:6: warning: 'nitems' may be used uninitialized in this function

Introduced by commit 16cdcec736cd ("btrfs: implement delayed inode items
operation"). I think this is a real bug. This variable is not
initialised, only incremented and tested.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/

P.S. Chris, time to get a tree into linux-next?

Attachments:

(No filename) (589.00 B)
(No filename) (490.00 B)
Download all attachments

2011-06-03 14:18:41

by David Sterba

[permalink] [raw]

Subject: Re: linux-next: build warning from Linus' tree

Hi,

On Fri, Jun 03, 2011 at 11:10:49AM +1000, Stephen Rothwell wrote:
> fs/btrfs/delayed-inode.c: In function 'btrfs_batch_insert_items':
> fs/btrfs/delayed-inode.c:670:6: warning: 'nitems' may be used uninitialized in this function
>
> Introduced by commit 16cdcec736cd ("btrfs: implement delayed inode items
> operation"). I think this is a real bug. This variable is not
> initialised, only incremented and tested.

yes, it's a bug and has been already hit (fix pending):

http://marc.info/?l=linux-btrfs&m=130678270307885&w=4

thanks,
david