2011-06-09 17:31:10

by Steven Rostedt

Subject: [PATCH 14/15] stack_trace: Add weak save_stack_trace_regs()

From: Masami Hiramatsu <[email protected]>

Add weak symbol of save_stack_trace_regs() as same as
save_stack_trace_tsk() since that is not implemented
except x86 yet.

Cc: Ingo Molnar <[email protected]>
Cc: [email protected]
Signed-off-by: Masami Hiramatsu <[email protected]>
Cc: Frederic Weisbecker <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: [email protected]
Link: http://lkml.kernel.org/r/20110608070927.17777.37895.stgit@fedora15
Signed-off-by: Steven Rostedt <[email protected]>
---
kernel/stacktrace.c | 13 ++++++++++---
1 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/kernel/stacktrace.c b/kernel/stacktrace.c
index eb212f8..6fa38bc 100644
--- a/kernel/stacktrace.c
+++ b/kernel/stacktrace.c
@@ -26,12 +26,19 @@ void print_stack_trace(struct stack_trace *trace, int spaces)
EXPORT_SYMBOL_GPL(print_stack_trace);

/*
- * Architectures that do not implement save_stack_trace_tsk get this
- * weak alias and a once-per-bootup warning (whenever this facility
- * is utilized - for example by procfs):
+ * Architectures that do not implement save_stack_trace_tsk or
+ * save_stack_trace_regs get this weak alias and a once-per-bootup warning
+ * (whenever this facility is utilized - for example by procfs):
*/
__weak void
save_stack_trace_tsk(struct task_struct *tsk, struct stack_trace *trace)
{
WARN_ONCE(1, KERN_INFO "save_stack_trace_tsk() not implemented yet.\n");
}
+
+__weak void
+save_stack_trace_regs(struct pt_regs *regs, struct stack_trace *trace)
+{
+ WARN_ONCE(1,
+ KERN_INFO "save_stack_trace_regs() not implemented yet.\n");
+}
--
1.7.4.4

2011-06-13 10:20:11

by Ingo Molnar

Subject: Re: [PATCH 14/15] stack_trace: Add weak save_stack_trace_regs()

* Steven Rostedt <[email protected]> wrote:

> +save_stack_trace_regs(struct pt_regs *regs, struct stack_trace *trace)
> +{
> + WARN_ONCE(1,
> + KERN_INFO "save_stack_trace_regs() not implemented yet.\n");

- pointless linebreak
- we don't add KERN_ tags to WARN*() invocations

Thanks,

Ingo

2011-06-13 10:52:16

by 平松雅巳 / HIRAMATU，MASAMI

Subject: Re: [PATCH 14/15] stack_trace: Add weak save_stack_trace_regs()

(2011/06/13 19:19), Ingo Molnar wrote:
>
> * Steven Rostedt <[email protected]> wrote:
>
>> +save_stack_trace_regs(struct pt_regs *regs, struct stack_trace *trace)
>> +{
>> + WARN_ONCE(1,
>> + KERN_INFO "save_stack_trace_regs() not implemented yet.\n");
>
> - pointless linebreak
> - we don't add KERN_ tags to WARN*() invocations

Hm, I just copied save_stack_trace_tsk(). OK, I'll remove it.

Thanks!

>
> Thanks,
>
> Ingo


--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: [email protected]

2011-06-13 11:42:25

by Ingo Molnar

Subject: Re: [PATCH 14/15] stack_trace: Add weak save_stack_trace_regs()

* Masami Hiramatsu <[email protected]> wrote:

> (2011/06/13 19:19), Ingo Molnar wrote:
> >
> > * Steven Rostedt <[email protected]> wrote:
> >
> >> +save_stack_trace_regs(struct pt_regs *regs, struct stack_trace *trace)
> >> +{
> >> + WARN_ONCE(1,
> >> + KERN_INFO "save_stack_trace_regs() not implemented yet.\n");
> >
> > - pointless linebreak
> > - we don't add KERN_ tags to WARN*() invocations
>
> Hm, I just copied save_stack_trace_tsk(). OK, I'll remove it.

Please remove it from save_stack_trace_tsk() as well.

Thanks,

Ingo