2011-06-27 15:56:19

by Prateek Sharma

[permalink] [raw]
Subject: Re: Linux 3.0-rc4 - fail to compile...

Will this issue be be please fixed in rc5 ? Not being able to even
compile it is a big hindrance.


> -----Original Message-----
> From: [email protected] [mailto:[email protected]] On Behalf Of Paul Rolland (???・???)
>
> Sent: Tuesday, June 21, 2011 3:14 PM
> To: Linus Torvalds
> Cc: Linux Kernel Mailing List; [email protected]
> Subject: Re: Linux 3.0-rc4 - fail to compile...
> Hello,
>
> On Mon, 20 Jun 2011 21:02:56 -0700
>
> Linus Torvalds <[email protected]> wrote:
>
> > Mostly the usual small driver one- (or few-) liners, and some bigger
> > changes to drm (and md). But also two new smallish drivers
>
> > (net/usb/kalmia.c, and the ADP8870 backlight driver). Some filesystem
> > fixes (btrfs, cifs, afs, xfs, nfsd).
>
> This is failing to compile on my machine :
> ...
> CC mm/page_cgroup.o
> CC fs/direct-io.o
>
> mm/page_cgroup.c: In function ‘page_cgroup_init’:
> mm/page_cgroup.c:308: error: implicit declaration of function ‘node_start_pfn’
> mm/page_cgroup.c:309: error: implicit declaration of function ‘node_end_pfn’
> make[1]: *** [mm/page_cgroup.o] Error 1
>
> make: *** [mm] Error 2
> make: *** Waiting for unfinished jobs....
> CC fs/mpage.o
> CC fs/ioprio.o
> This seems to be caused by arch/x86/include/asm/mmzone_64.h which only defines
> node_start_pfn and node_end_pfn if CONFIG_NUMA is set.
>
>
> Adding CONFIG_NUMA to my .config fixes the issue.
>
> Paul


2011-06-27 16:20:24

by Randy Dunlap

[permalink] [raw]
Subject: Re: Linux 3.0-rc4 - fail to compile...

On Mon, 27 Jun 2011 21:25:55 +0530 Prateek Sharma wrote:

> Will this issue be be please fixed in rc5 ? Not being able to even
> compile it is a big hindrance.

I asked Andrew to merge the patch for this but I haven't seen any email
from him recently, so maybe someone else needs to merge the patch.

http://marc.info/?l=linux-mm&m=130827204306775&w=2

Acked-by: Mel Gorman <[email protected]>
Acked-by: Randy Dunlap <[email protected]>



> > -----Original Message-----
> > From: [email protected] [mailto:[email protected]] On Behalf Of Paul Rolland (???・???)
> >
> > Sent: Tuesday, June 21, 2011 3:14 PM
> > To: Linus Torvalds
> > Cc: Linux Kernel Mailing List; [email protected]
> > Subject: Re: Linux 3.0-rc4 - fail to compile...
> > Hello,
> >
> > On Mon, 20 Jun 2011 21:02:56 -0700
> >
> > Linus Torvalds <[email protected]> wrote:
> >
> > > Mostly the usual small driver one- (or few-) liners, and some bigger
> > > changes to drm (and md). But also two new smallish drivers
> >
> > > (net/usb/kalmia.c, and the ADP8870 backlight driver). Some filesystem
> > > fixes (btrfs, cifs, afs, xfs, nfsd).
> >
> > This is failing to compile on my machine :
> > ...
> > CC mm/page_cgroup.o
> > CC fs/direct-io.o
> >
> > mm/page_cgroup.c: In function ‘page_cgroup_init’:
> > mm/page_cgroup.c:308: error: implicit declaration of function ‘node_start_pfn’
> > mm/page_cgroup.c:309: error: implicit declaration of function ‘node_end_pfn’
> > make[1]: *** [mm/page_cgroup.o] Error 1
> >
> > make: *** [mm] Error 2
> > make: *** Waiting for unfinished jobs....
> > CC fs/mpage.o
> > CC fs/ioprio.o
> > This seems to be caused by arch/x86/include/asm/mmzone_64.h which only defines
> > node_start_pfn and node_end_pfn if CONFIG_NUMA is set.
> >
> >
> > Adding CONFIG_NUMA to my .config fixes the issue.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***