2012-10-25 06:00:27

by Bin Gao

Subject: arch/x86/Kconfig: not select X86_MPPARSE when SFI is present

MPS tables are not needed for systems that have proper ACPI support.
This is also true for systems that have SFI in place.

So this patch is to exclude X86_MPPARSE when either ACPI or SFI is present.

Signed-off-by: Bin Gao <[email protected]>
---
arch/x86/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 46c3bff..b1494bd 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -310,7 +310,7 @@ config X86_X2APIC
If you don't know what to do here, say N.

config X86_MPPARSE
- bool "Enable MPS table" if ACPI
+ bool "Enable MPS table" if ACPI || SFI
default y
depends on X86_LOCAL_APIC
---help---
--
1.7.4.4

2012-10-25 07:58:09

by Ingo Molnar

Subject: Re: arch/x86/Kconfig: not select X86_MPPARSE when SFI is present

* Bin Gao <[email protected]> wrote:

> MPS tables are not needed for systems that have proper ACPI support.
> This is also true for systems that have SFI in place.
>
> So this patch is to exclude X86_MPPARSE when either ACPI or SFI is present.
>
> Signed-off-by: Bin Gao <[email protected]>
> ---
> arch/x86/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 46c3bff..b1494bd 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -310,7 +310,7 @@ config X86_X2APIC
> If you don't know what to do here, say N.
>
> config X86_MPPARSE
> - bool "Enable MPS table" if ACPI
> + bool "Enable MPS table" if ACPI || SFI
> default y
> depends on X86_LOCAL_APIC
> ---help---

The changelog does not seem to match the patch. Did you want to
say:

" So this patch allows the configuration (turning off) of
CONFIG_X86_MPPARSE when either ACPI or SFI is present. "

?

Ingo

2012-10-26 09:01:39

by Bin Gao

Subject: Re: arch/x86/Kconfig: not select X86_MPPARSE when SFI is present

Yes, your suggested descriptions more match the change.
I'm sending a new patch for your review. Thanks.

-Bin

On Thu, Oct 25, 2012 at 09:57:52AM +0200, Ingo Molnar wrote:
>
> * Bin Gao <[email protected]> wrote:
>
> > MPS tables are not needed for systems that have proper ACPI support.
> > This is also true for systems that have SFI in place.
> >
> > So this patch is to exclude X86_MPPARSE when either ACPI or SFI is present.
> >
> > Signed-off-by: Bin Gao <[email protected]>
> > ---
> > arch/x86/Kconfig | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> > index 46c3bff..b1494bd 100644
> > --- a/arch/x86/Kconfig
> > +++ b/arch/x86/Kconfig
> > @@ -310,7 +310,7 @@ config X86_X2APIC
> > If you don't know what to do here, say N.
> >
> > config X86_MPPARSE
> > - bool "Enable MPS table" if ACPI
> > + bool "Enable MPS table" if ACPI || SFI
> > default y
> > depends on X86_LOCAL_APIC
> > ---help---
>
> The changelog does not seem to match the patch. Did you want to
> say:
>
> " So this patch allows the configuration (turning off) of
> CONFIG_X86_MPPARSE when either ACPI or SFI is present. "
>
> ?
>
> Ingo