2013-03-22 11:29:10

by Wei Yongjun

Subject: [PATCH -next] loopdev: fix error return code in loop_add()

From: Wei Yongjun <[email protected]>

Fix to return a negative error code from the error handling
case, as returned elsewhere in this function.

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/block/loop.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 1e0cc5a..4afe38e 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -1638,6 +1638,7 @@ static int loop_add(struct loop_device **l, int i)
goto out_free_dev;
i = err;

+ err = -ENOMEM;
lo->lo_queue = blk_alloc_queue(GFP_KERNEL);
if (!lo->lo_queue)
goto out_free_dev;

2013-03-22 15:00:07

by Jens Axboe

Subject: Re: [PATCH -next] loopdev: fix error return code in loop_add()

On Fri, Mar 22 2013, Wei Yongjun wrote:
> From: Wei Yongjun <[email protected]>
>
> Fix to return a negative error code from the error handling
> case, as returned elsewhere in this function.

Applied, thanks.

--
Jens Axboe