2013-04-23 19:18:44

by Uwe Kleine-König

Subject: init-mainc-convert-to-pr_foo.patch is IMHO broken

Hello,

init-mainc-convert-to-pr_foo.patch breaks the initcall_debug kernel
parameter. Before the patch I could add

initcall_debug ignore_loglevel

to the kernel command line and got some additional output about
initcalls. Now that init/main.c uses pr_debug instead of
printk(KERN_DEBUG ...) the interesting statements are not compiled in
any more.

Best regards
Uwe

PS: sorry for not doing a proper reply but I didn't find something suitable
to reply to.


--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |

2013-04-23 19:26:20

by Andrew Morton

Subject: Re: init-mainc-convert-to-pr_foo.patch is IMHO broken

On Tue, 23 Apr 2013 21:18:39 +0200 Uwe Kleine-K__nig <[email protected]> wrote:

> Hello,
>
> init-mainc-convert-to-pr_foo.patch breaks the initcall_debug kernel
> parameter. Before the patch I could add
>
> initcall_debug ignore_loglevel
>
> to the kernel command line and got some additional output about
> initcalls. Now that init/main.c uses pr_debug instead of
> printk(KERN_DEBUG ...) the interesting statements are not compiled in
> any more.
>

huh. pr_debug() is different from all the other pr_foo()s. I never
noticed that.

This?

--- a/init/main.c~init-mainc-convert-to-pr_foo-fix
+++ a/init/main.c
@@ -9,6 +9,8 @@
* Simplified starting of init: Michael A. Griffith <[email protected]>
*/

+#define DEBUG
+
#include <linux/types.h>
#include <linux/module.h>
#include <linux/proc_fs.h>
_