2013-04-24 12:46:48

by Geert Uytterhoeven

Subject: [PATCH] isdn/sc: Fix incorrect module_param_array types

drivers/isdn/sc/init.c: In function ‘__check_irq’:
drivers/isdn/sc/init.c:36: warning: return from incompatible pointer type
drivers/isdn/sc/init.c: In function ‘__check_ram’:
drivers/isdn/sc/init.c:37: warning: return from incompatible pointer type

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/isdn/sc/init.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/isdn/sc/init.c b/drivers/isdn/sc/init.c
index 6b580b2..ca997bd 100644
--- a/drivers/isdn/sc/init.c
+++ b/drivers/isdn/sc/init.c
@@ -33,8 +33,8 @@ static unsigned long ram[] = {0, 0, 0, 0};
static bool do_reset = 0;

module_param_array(io, int, NULL, 0);
-module_param_array(irq, int, NULL, 0);
-module_param_array(ram, int, NULL, 0);
+module_param_array(irq, byte, NULL, 0);
+module_param_array(ram, long, NULL, 0);
module_param(do_reset, bool, 0);

static int identify_board(unsigned long, unsigned int);
--
1.7.0.4

2013-04-25 08:24:20

by David Miller

Subject: Re: [PATCH] isdn/sc: Fix incorrect module_param_array types

From: Geert Uytterhoeven <[email protected]>
Date: Wed, 24 Apr 2013 14:46:37 +0200

> drivers/isdn/sc/init.c: In function ?__check_irq?:
> drivers/isdn/sc/init.c:36: warning: return from incompatible pointer type
> drivers/isdn/sc/init.c: In function ?__check_ram?:
> drivers/isdn/sc/init.c:37: warning: return from incompatible pointer type
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Applied.
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?