It is necessary to clear MC13892_SWITCHERS0_SWxHI bit when set voltage to the
voltage range from 1100000 to 1375000. Leaving MC13892_SWITCHERS0_SWxHI bit
untouched may result in wrong voltage setting.
For example, currently switch voltage from 1400000 to 1300000 will set the
voltage to 1800000 because the HI bit is still set.
Signed-off-by: Axel Lin <[email protected]>
---
drivers/regulator/mc13892-regulator.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/regulator/mc13892-regulator.c b/drivers/regulator/mc13892-regulator.c
index 9891aec..cc76c52 100644
--- a/drivers/regulator/mc13892-regulator.c
+++ b/drivers/regulator/mc13892-regulator.c
@@ -465,13 +465,13 @@ static int mc13892_sw_regulator_set_voltage_sel(struct regulator_dev *rdev,
*/
if (mc13892_regulators[id].vsel_reg != MC13892_SWITCHERS0) {
+ mask |= MC13892_SWITCHERS0_SWxHI;
+
if (volt > 1375000) {
reg_value -= MC13892_SWxHI_SEL_OFFSET;
reg_value |= MC13892_SWITCHERS0_SWxHI;
- mask |= MC13892_SWITCHERS0_SWxHI;
- } else if (volt < 1100000) {
+ } else {
reg_value &= ~MC13892_SWITCHERS0_SWxHI;
- mask |= MC13892_SWITCHERS0_SWxHI;
}
}
--
1.7.10.4
On Wed, Apr 24, 2013 at 11:51:12AM +0800, Axel Lin wrote:
> It is necessary to clear MC13892_SWITCHERS0_SWxHI bit when set voltage to the
> voltage range from 1100000 to 1375000. Leaving MC13892_SWITCHERS0_SWxHI bit
> untouched may result in wrong voltage setting.
Applied, thanks.
On Wed, Apr 24, 2013 at 11:51:12AM +0800, Axel Lin wrote:
> It is necessary to clear MC13892_SWITCHERS0_SWxHI bit when set voltage to the
> voltage range from 1100000 to 1375000. Leaving MC13892_SWITCHERS0_SWxHI bit
> untouched may result in wrong voltage setting.
Applied, thanks.