2013-05-02 19:43:40

by Gregory CLEMENT

Subject: [PATCH] ARM: kirkwood: add button for OpenBlock A6

The OpenBlocks A6 board has one software-controlled button on the
front side, labeled "INIT", so we add minimal support for this button
in the kernel.

Signed-off-by: Gregory CLEMENT <[email protected]>
---
arch/arm/boot/dts/kirkwood-openblocks_a6.dts | 13 +++++++++++++
1 file changed, 13 insertions(+)

diff --git a/arch/arm/boot/dts/kirkwood-openblocks_a6.dts b/arch/arm/boot/dts/kirkwood-openblocks_a6.dts
index d27f724..627d8d0 100644
--- a/arch/arm/boot/dts/kirkwood-openblocks_a6.dts
+++ b/arch/arm/boot/dts/kirkwood-openblocks_a6.dts
@@ -209,4 +209,17 @@
gpios = <&gpio1 11 1>;
};
};
+
+ gpio_keys {
+ compatible = "gpio-keys";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ button@1 {
+ label = "Init Button";
+ linux,code = <116>;
+ gpios = <&gpio1 6 0>;
+ };
+ };
+
};
--
1.7.9.5

2013-05-02 19:52:59

by Ezequiel Garcia

Subject: Re: [PATCH] ARM: kirkwood: add button for OpenBlock A6

Hi Gregory,

On Thu, May 02, 2013 at 09:43:22PM +0200, Gregory CLEMENT wrote:
> The OpenBlocks A6 board has one software-controlled button on the
> front side, labeled "INIT", so we add minimal support for this button
> in the kernel.
>
> Signed-off-by: Gregory CLEMENT <[email protected]>
> ---
> arch/arm/boot/dts/kirkwood-openblocks_a6.dts | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/kirkwood-openblocks_a6.dts b/arch/arm/boot/dts/kirkwood-openblocks_a6.dts
> index d27f724..627d8d0 100644
> --- a/arch/arm/boot/dts/kirkwood-openblocks_a6.dts
> +++ b/arch/arm/boot/dts/kirkwood-openblocks_a6.dts
> @@ -209,4 +209,17 @@
> gpios = <&gpio1 11 1>;
> };
> };
> +
> + gpio_keys {
> + compatible = "gpio-keys";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + button@1 {
> + label = "Init Button";
> + linux,code = <116>;
> + gpios = <&gpio1 6 0>;
> + };
> + };
> +
> };

Shouldn't you add a proper pinctrl entry for this as well?

--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com

2013-05-02 19:57:17

by Gregory CLEMENT

Subject: Re: [PATCH] ARM: kirkwood: add button for OpenBlock A6

On 05/02/2013 09:43 PM, Gregory CLEMENT wrote:
> The OpenBlocks A6 board has one software-controlled button on the
> front side, labeled "INIT", so we add minimal support for this button
> in the kernel.
>

Oh, I found that Thomas have already submitted the same patch but I was
misleaded because I didn't find anything related to this in v3.9,
nor in next-20130502.

You can drop this patch of course, but waht happens to Thomas' patch?

> Signed-off-by: Gregory CLEMENT <[email protected]>
> ---
> arch/arm/boot/dts/kirkwood-openblocks_a6.dts | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/kirkwood-openblocks_a6.dts b/arch/arm/boot/dts/kirkwood-openblocks_a6.dts
> index d27f724..627d8d0 100644
> --- a/arch/arm/boot/dts/kirkwood-openblocks_a6.dts
> +++ b/arch/arm/boot/dts/kirkwood-openblocks_a6.dts
> @@ -209,4 +209,17 @@
> gpios = <&gpio1 11 1>;
> };
> };
> +
> + gpio_keys {
> + compatible = "gpio-keys";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + button@1 {
> + label = "Init Button";
> + linux,code = <116>;
> + gpios = <&gpio1 6 0>;
> + };
> + };
> +
> };
>


--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

2013-05-02 21:45:59

by Thomas Petazzoni

Subject: Re: [PATCH] ARM: kirkwood: add button for OpenBlock A6

Dear Gregory CLEMENT,

On Thu, 02 May 2013 21:57:06 +0200, Gregory CLEMENT wrote:

> Oh, I found that Thomas have already submitted the same patch but I
> was misleaded because I didn't find anything related to this in v3.9,
> nor in next-20130502.
>
> You can drop this patch of course, but waht happens to Thomas' patch?

I have to rework it as part as a refactoring of the pinctrl definitions
on kirkwood. I'll try to work on that soon.

Thanks,

Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com