2013-05-15 16:09:34

by Luiz Capitulino

Subject: [PATCH] package: Makefile: unbreak binrpm-pkg target

Commit 6501320311664e11ad5489fedb17ea1f817c2617 dropped the rpm spec as a
prerequisite for the binrpm-pkg target but forgot to update $< usage,
which causes the rule to break.

This commit fixes that by replacing $< with the spec name.

Signed-off-by: Luiz Capitulino <[email protected]>
---
scripts/package/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/package/Makefile b/scripts/package/Makefile
index 84a4060..a4f31c9 100644
--- a/scripts/package/Makefile
+++ b/scripts/package/Makefile
@@ -63,7 +63,7 @@ binrpm-pkg: FORCE
mv -f $(objtree)/.tmp_version $(objtree)/.version

$(RPM) $(RPMOPTS) --define "_builddir $(objtree)" --target \
- $(UTS_MACHINE) -bb $<
+ $(UTS_MACHINE) -bb $(objtree)/binkernel.spec
rm binkernel.spec

# Deb target
--
1.8.1.4

2013-05-16 07:49:52

by Michal Marek

Subject: Re: [PATCH] package: Makefile: unbreak binrpm-pkg target

On Wed, May 15, 2013 at 12:06:26PM -0400, Luiz Capitulino wrote:
> Commit 6501320311664e11ad5489fedb17ea1f817c2617 dropped the rpm spec as a
> prerequisite for the binrpm-pkg target but forgot to update $< usage,
> which causes the rule to break.

Oops :)


> This commit fixes that by replacing $< with the spec name.

Thanks for the fix, I added it to kbuild.git#rc-fixes.

Michal