2013-07-05 14:49:23

by Waiman Long

Subject: [PATCH v5 11/12] nilfs2: replace direct access of d_count with the d_count() helper

Because of the d_count change made in dcache.h, all readonly references
to d_count have to be changed to use the new d_count() helper as they
shouldn't access its value directly. There is no change in logic
and everything should just work.

Signed-off-by: Waiman Long <[email protected]>
---
fs/nilfs2/super.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c
index c7d1f9f..bd9d1f2 100644
--- a/fs/nilfs2/super.c
+++ b/fs/nilfs2/super.c
@@ -973,7 +973,7 @@ static int nilfs_attach_snapshot(struct super_block *s, __u64 cno,

static int nilfs_tree_was_touched(struct dentry *root_dentry)
{
- return root_dentry->d_count > 1;
+ return d_count(root_dentry) > 1;
}

/**
--
1.7.1

2013-07-06 10:47:11

by Ryusuke Konishi

Subject: Re: [PATCH v5 11/12] nilfs2: replace direct access of d_count with the d_count() helper

On Fri, 5 Jul 2013 10:48:29 -0400, Waiman Long <[email protected]> wrote:
> Because of the d_count change made in dcache.h, all readonly references
> to d_count have to be changed to use the new d_count() helper as they
> shouldn't access its value directly. There is no change in logic
> and everything should just work.
>
> Signed-off-by: Waiman Long <[email protected]>

Acked-by: Ryusuke Konishi <[email protected]>


Thanks,
Ryusuke Konishi

> ---
> fs/nilfs2/super.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c
> index c7d1f9f..bd9d1f2 100644
> --- a/fs/nilfs2/super.c
> +++ b/fs/nilfs2/super.c
> @@ -973,7 +973,7 @@ static int nilfs_attach_snapshot(struct super_block *s, __u64 cno,
>
> static int nilfs_tree_was_touched(struct dentry *root_dentry)
> {
> - return root_dentry->d_count > 1;
> + return d_count(root_dentry) > 1;
> }
>
> /**
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html