2013-07-11 12:25:12

by Julien Delacou

Subject: [PATCH] staging: dwc2: fix value used in dwc2_set_all_params

From: Julien Delacou <[email protected]>

This fix uses 'value' parameter as it should be instead
of hardcoded -1.

Signed-off-by: Julien Delacou <[email protected]>
Acked-by: Paul Zimmerman <[email protected]>
---
drivers/staging/dwc2/hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/dwc2/hcd.c b/drivers/staging/dwc2/hcd.c
index 2ed54b1..ca38aaa 100644
--- a/drivers/staging/dwc2/hcd.c
+++ b/drivers/staging/dwc2/hcd.c
@@ -2690,7 +2690,7 @@ void dwc2_set_all_params(struct dwc2_core_params *params, int value)
int i;

for (i = 0; i < size; i++)
- p[i] = -1;
+ p[i] = value;
}
EXPORT_SYMBOL_GPL(dwc2_set_all_params);

--
1.7.9.5

2013-07-11 16:30:48

by Matthijs Kooijman

Subject: Re: [PATCH] staging: dwc2: fix value used in dwc2_set_all_params

On Thu, Jul 11, 2013 at 02:24:10PM +0200, Julien Delacou wrote:
> From: Julien Delacou <[email protected]>
>
> This fix uses 'value' parameter as it should be instead
> of hardcoded -1.
Woops!

> Signed-off-by: Julien Delacou <[email protected]>
> Acked-by: Paul Zimmerman <[email protected]>
Reviewed-by: Matthijs Kooijman <[email protected]>

> ---
> drivers/staging/dwc2/hcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/dwc2/hcd.c b/drivers/staging/dwc2/hcd.c
> index 2ed54b1..ca38aaa 100644
> --- a/drivers/staging/dwc2/hcd.c
> +++ b/drivers/staging/dwc2/hcd.c
> @@ -2690,7 +2690,7 @@ void dwc2_set_all_params(struct dwc2_core_params *params, int value)
> int i;
>
> for (i = 0; i < size; i++)
> - p[i] = -1;
> + p[i] = value;
> }
> EXPORT_SYMBOL_GPL(dwc2_set_all_params);
>
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html