2013-10-10 20:28:10

by Wim Van Sebroeck

[permalink] [raw]
Subject: [GIT PULL REQUEST] watchdog - v3.12-rc4 Fixes

Hi Linus,

Please pull from 'master' branch of
git://http://www.linux-watchdog.org/linux-watchdog.git

It will make sure that the hpwdt driver will not load auxilary iLO devices.

This will update the following files:

hpwdt.c | 6 ++++++
1 files changed, 6 insertions(+)

with these Changes:

commit 0821f20d49d19f49e53b05ef6727e010c4b1f11d
Author: Mingarelli, Thomas <[email protected]>
Date: Fri Aug 9 16:31:09 2013 +0000

watchdog: hpwdt: Patch to ignore auxilary iLO devices

This patch is to prevent hpwdt from loading on any auxilary iLO devices defined
after the initial (or main) iLO device. All auxilary iLO devices will have a
subsystem device ID set to 0x1979 in order for hpwdt to differentiate between
the two types.

Signed-off-by: Thomas Mingarelli <[email protected]>
Tested-by: Lisa Mitchell <[email protected]>
Signed-off-by: Wim Van Sebroeck <[email protected]>

For completeness, I added the overal diff below.

Greetings,
Wim.

================================================================================
commit 0821f20d49d19f49e53b05ef6727e010c4b1f11d
Author: Mingarelli, Thomas <[email protected]>
Date: Fri Aug 9 16:31:09 2013 +0000

watchdog: hpwdt: Patch to ignore auxilary iLO devices

This patch is to prevent hpwdt from loading on any auxilary iLO devices defined
after the initial (or main) iLO device. All auxilary iLO devices will have a
subsystem device ID set to 0x1979 in order for hpwdt to differentiate between
the two types.

Signed-off-by: Thomas Mingarelli <[email protected]>
Tested-by: Lisa Mitchell <[email protected]>
Signed-off-by: Wim Van Sebroeck <[email protected]>

diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
index 5be5e3d..19f3c3f 100644
--- a/drivers/watchdog/hpwdt.c
+++ b/drivers/watchdog/hpwdt.c
@@ -802,6 +802,12 @@ static int hpwdt_init_one(struct pci_dev *dev,
return -ENODEV;
}

+ /*
+ * Ignore all auxilary iLO devices with the following PCI ID
+ */
+ if (dev->subsystem_device == 0x1979)
+ return -ENODEV;
+
if (pci_enable_device(dev)) {
dev_warn(&dev->dev,
"Not possible to enable PCI Device: 0x%x:0x%x.\n",