2014-02-21 08:07:34

by Nenghua Cao

[permalink] [raw]
Subject: [PATCH 1/2] driver: regmap: fix coccinelle warnings

From: Nenghua Cao <[email protected]>

/drivers/base/regmap/regmap.c:717:6-33: WARNING:
Comparison to bool.

More information about semantic patching is available at
http://coccinelle.lip6.fr/

Signed-off-by: Nenghua Cao <[email protected]>
---
drivers/base/regmap/regmap.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
index 4b2ed0c..78fc54c 100644
--- a/drivers/base/regmap/regmap.c
+++ b/drivers/base/regmap/regmap.c
@@ -718,7 +718,7 @@ skip_format_initialization:
new->window_start = range_cfg->window_start;
new->window_len = range_cfg->window_len;

- if (_regmap_range_add(map, new) == false) {
+ if (!_regmap_range_add(map, new)) {
dev_err(map->dev, "Failed to add range %d\n", i);
kfree(new);
goto err_range;
--
1.7.0.4


2014-02-22 02:49:22

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH 1/2] driver: regmap: fix coccinelle warnings

On Fri, Feb 21, 2014 at 04:05:45PM +0800, Nenghua Cao wrote:
> From: Nenghua Cao <[email protected]>
>
> /drivers/base/regmap/regmap.c:717:6-33: WARNING:
> Comparison to bool.

Applied, thanks. Please use subject lines consistent with the
subsystem.


Attachments:
(No filename) (255.00 B)
signature.asc (836.00 B)
Digital signature
Download all attachments