2014-04-21 13:23:14

by Alexander Gordeev

[permalink] [raw]
Subject: Re: [PATCH v2 RESEND 3/4] tsi721: Use pci_enable_msix_exact() instead of pci_enable_msix()

On Fri, Mar 07, 2014 at 01:35:34PM +0000, Bounine, Alexandre wrote:
> > From: Alexander Gordeev [mailto:[email protected]]
> > Sent: Thursday, March 06, 2014 3:11 PM
> > To: [email protected]
> > Cc: Alexander Gordeev; Matt Porter; Bounine, Alexandre; linux-
> > [email protected]
> > Subject: [PATCH v2 RESEND 3/4] tsi721: Use pci_enable_msix_exact()
> > instead of pci_enable_msix()
> >
> > As result of deprecation of MSI-X/MSI enablement functions
> > pci_enable_msix() and pci_enable_msi_block() all drivers
> > using these two interfaces need to be updated to use the
> > new pci_enable_msi_range() or pci_enable_msi_exact()
> > and pci_enable_msix_range() or pci_enable_msix_exact()
> > interfaces.
>
>
> Acked-by: Alexandre Bounine <[email protected]>
>
> Andrew, please pick up this patch for the -next tree.

Hi Andrew,

Could you please pick up this patch?

Thanks!

> > Signed-off-by: Alexander Gordeev <[email protected]>
> > Cc: Matt Porter <[email protected]>
> > Cc: Alexandre Bounine <[email protected]>
> > Cc: [email protected]
> > ---
> > drivers/rapidio/devices/tsi721.c | 11 +++--------
> > 1 files changed, 3 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/rapidio/devices/tsi721.c
> > b/drivers/rapidio/devices/tsi721.c
> > index ff7cbf2..ce08e8d 100644
> > --- a/drivers/rapidio/devices/tsi721.c
> > +++ b/drivers/rapidio/devices/tsi721.c
> > @@ -768,15 +768,10 @@ static int tsi721_enable_msix(struct
> > tsi721_device *priv)
> > }
> > #endif /* CONFIG_RAPIDIO_DMA_ENGINE */
> >
> > - err = pci_enable_msix(priv->pdev, entries, ARRAY_SIZE(entries));
> > + err = pci_enable_msix_exact(priv->pdev, entries,
> > ARRAY_SIZE(entries));
> > if (err) {
> > - if (err > 0)
> > - dev_info(&priv->pdev->dev,
> > - "Only %d MSI-X vectors available, "
> > - "not using MSI-X\n", err);
> > - else
> > - dev_err(&priv->pdev->dev,
> > - "Failed to enable MSI-X (err=%d)\n", err);
> > + dev_err(&priv->pdev->dev,
> > + "Failed to enable MSI-X (err=%d)\n", err);
> > return err;
> > }
> >
> > --
> > 1.7.7.6
>