2014-04-29 00:22:30

by Masanari Iida

Subject: [PATCH] oprofile: Fix format string mismatch in oprofile_perf.c

Fix format string mismatch in oprofile_perf_create_files.

Signed-off-by: Masanari Iida <[email protected]>
---
drivers/oprofile/oprofile_perf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/oprofile/oprofile_perf.c b/drivers/oprofile/oprofile_perf.c
index d5b2732..968e6dc 100644
--- a/drivers/oprofile/oprofile_perf.c
+++ b/drivers/oprofile/oprofile_perf.c
@@ -146,7 +146,7 @@ static int oprofile_perf_create_files(struct dentry *root)
struct dentry *dir;
char buf[4];

- snprintf(buf, sizeof buf, "%d", i);
+ snprintf(buf, sizeof buf, "%u", i);
dir = oprofilefs_mkdir(root, buf);
oprofilefs_create_ulong(dir, "enabled", &counter_config[i].enabled);
oprofilefs_create_ulong(dir, "event", &counter_config[i].event);
--
2.0.0.rc1

2014-04-29 08:13:05

by Robert Richter

Subject: Re: [PATCH] oprofile: Fix format string mismatch in oprofile_perf.c

On 29.04.14 09:22:20, Masanari Iida wrote:
> Fix format string mismatch in oprofile_perf_create_files.

Please provide a compiler warning.

>
> Signed-off-by: Masanari Iida <[email protected]>
> ---
> drivers/oprofile/oprofile_perf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/oprofile/oprofile_perf.c b/drivers/oprofile/oprofile_perf.c
> index d5b2732..968e6dc 100644
> --- a/drivers/oprofile/oprofile_perf.c
> +++ b/drivers/oprofile/oprofile_perf.c
> @@ -146,7 +146,7 @@ static int oprofile_perf_create_files(struct dentry *root)

unsigned int i;

for (i = 0; i < num_counters; i++) {

> struct dentry *dir;
> char buf[4];
>
> - snprintf(buf, sizeof buf, "%d", i);
> + snprintf(buf, sizeof buf, "%u", i);

Since num_counters is int we better fix this by changing the i
declaration to int which avoids comparing unsigned/signed.

-Robert

> dir = oprofilefs_mkdir(root, buf);
> oprofilefs_create_ulong(dir, "enabled", &counter_config[i].enabled);
> oprofilefs_create_ulong(dir, "event", &counter_config[i].event);
> --
> 2.0.0.rc1
>