2014-07-22 00:58:13

by Guillaume Morin

Subject: [PATCH] staging: llite: rw.c: use gfp_t to store GFP flags

Use gfp_t to store GPF_* flags instead of unsigned int.
This was reported by sparse.

Signed-off-by: Guillaume Morin <[email protected]>
---
drivers/staging/lustre/lustre/llite/rw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/llite/rw.c b/drivers/staging/lustre/lustre/llite/rw.c
index 5616210..3554272 100644
--- a/drivers/staging/lustre/lustre/llite/rw.c
+++ b/drivers/staging/lustre/lustre/llite/rw.c
@@ -496,7 +496,7 @@ static int ll_read_ahead_page(const struct lu_env *env, struct cl_io *io,
struct cl_object *clob = ll_i2info(mapping->host)->lli_clob;
struct cl_page *page;
enum ra_stat which = _NR_RA_STAT; /* keep gcc happy */
- unsigned int gfp_mask;
+ gfp_t gfp_mask;
int rc = 0;
const char *msg = NULL;

--
1.9.1

2014-07-22 02:08:09

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: llite: rw.c: use gfp_t to store GFP flags

On Tue, Jul 22, 2014 at 02:57:57AM +0200, Guillaume Morin wrote:
> Use gfp_t to store GPF_* flags instead of unsigned int.
> This was reported by sparse.
>
> Signed-off-by: Guillaume Morin <[email protected]>
> ---
> drivers/staging/lustre/lustre/llite/rw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/llite/rw.c b/drivers/staging/lustre/lustre/llite/rw.c
> index 5616210..3554272 100644
> --- a/drivers/staging/lustre/lustre/llite/rw.c
> +++ b/drivers/staging/lustre/lustre/llite/rw.c
> @@ -496,7 +496,7 @@ static int ll_read_ahead_page(const struct lu_env *env, struct cl_io *io,
> struct cl_object *clob = ll_i2info(mapping->host)->lli_clob;
> struct cl_page *page;
> enum ra_stat which = _NR_RA_STAT; /* keep gcc happy */
> - unsigned int gfp_mask;
> + gfp_t gfp_mask;

Odd thing is, that function doesn't seem to even use that variable
anywhere... Can you just remove it entirely?

thanks,

greg k-h

2014-07-22 02:47:46

by Guillaume Morin

Subject: Re: [PATCH] staging: llite: rw.c: use gfp_t to store GFP flags

On 21 Jul 19:08, Greg KH wrote:
> Odd thing is, that function doesn't seem to even use that variable
> anywhere... Can you just remove it entirely?

Oh that's right. Resubmitted.

Thanks

Guillaume.

--
Guillaume Morin <[email protected]>