2014-11-11 06:03:13

by Jisheng Zhang

[permalink] [raw]
Subject: Re: [PATCH 0/3] irqchip: dw-apb-ictl: IRQ_GC_MASK_CACHE_PER_TYPE and PM support

Dear Thomas, Jason,

Is there any potential issue with this patch serials I need to resolve?

Thanks in advance,
Jisheng

On Mon, 22 Sep 2014 23:34:57 -0700
Jisheng Zhang <[email protected]> wrote:

> These patches try to improve dw-apb-ictl irqchip driver a bit.
>
> The first patch does a bit clean up work -- unify the register access usage.
>
> The two dw-apb-ictl's irq_chip_type instances have separate mask registers,
> so the second patch enables IRQ_GC_MASK_CACHE_PER_TYPE.
>
> The last patch adds suspend/resume support to the driver.
>
> Tested on Marvell BG2Q-DMP board.
>
> Jisheng Zhang (3):
> irqchip: dw-apb-ictl: always use use {readl|writel}_relaxed
> irqchip: dw-apb-ictl: enable IRQ_GC_MASK_CACHE_PER_TYPE
> irqchip: dw-apb-ictl: add PM support
>
> drivers/irqchip/irq-dw-apb-ictl.c | 32 ++++++++++++++++++++++++++------
> 1 file changed, 26 insertions(+), 6 deletions(-)
>


2014-11-11 13:45:55

by Jason Cooper

[permalink] [raw]
Subject: Re: [PATCH 0/3] irqchip: dw-apb-ictl: IRQ_GC_MASK_CACHE_PER_TYPE and PM support

On Tue, Nov 11, 2014 at 01:59:47PM +0800, Jisheng Zhang wrote:
> Dear Thomas, Jason,
>
> Is there any potential issue with this patch serials I need to resolve?

Please send a v2 with Sebastian's Acks. Also, please update the commit
log on #1 as requested. For #3, Please add a summary of the discussion
to its commit log. eg: "We can used relaxed variants here because..."

thx,

Jason.