This patch enables the phy drivers for the SATA controller on Marvell's 88f6192. Without them it is not possible to use SATA drives attached to this processor.
Signed-off-by: Evgeni Dobrev <[email protected]>
---
arch/arm/boot/dts/kirkwood-6192.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/kirkwood-6192.dtsi b/arch/arm/boot/dts/kirkwood-6192.dtsi
index dd81508..bed2dec 100644
--- a/arch/arm/boot/dts/kirkwood-6192.dtsi
+++ b/arch/arm/boot/dts/kirkwood-6192.dtsi
@@ -66,6 +66,8 @@
interrupts = <21>;
clocks = <&gate_clk 14>, <&gate_clk 15>;
clock-names = "0", "1";
+ phys = <&sata_phy0>, <&sata_phy1>;
+ phy-names = "port0", "port1";
status = "disabled";
};
--
1.7.10.4
On Mon, Dec 15, 2014 at 09:37:24PM +0100, Evgeni Dobrev wrote:
> This patch enables the phy drivers for the SATA controller on Marvell's 88f6192. Without them it is not possible to use SATA drives attached to this processor.
>
> Signed-off-by: Evgeni Dobrev <[email protected]>
Acked-by: Andrew Lunn <[email protected]>
This should also go to stable.
Andrew
> ---
> arch/arm/boot/dts/kirkwood-6192.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/kirkwood-6192.dtsi b/arch/arm/boot/dts/kirkwood-6192.dtsi
> index dd81508..bed2dec 100644
> --- a/arch/arm/boot/dts/kirkwood-6192.dtsi
> +++ b/arch/arm/boot/dts/kirkwood-6192.dtsi
> @@ -66,6 +66,8 @@
> interrupts = <21>;
> clocks = <&gate_clk 14>, <&gate_clk 15>;
> clock-names = "0", "1";
> + phys = <&sata_phy0>, <&sata_phy1>;
> + phy-names = "port0", "port1";
> status = "disabled";
> };
>
> --
> 1.7.10.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hello.
On 12/15/2014 11:37 PM, Evgeni Dobrev wrote:
> This patch enables the phy drivers for the SATA controller on Marvell's 88f6192. Without them it is not possible to use SATA drives attached to this processor.
Please wrap the change log likes at 80 characters or less.
> Signed-off-by: Evgeni Dobrev <[email protected]>
> ---
> arch/arm/boot/dts/kirkwood-6192.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
> diff --git a/arch/arm/boot/dts/kirkwood-6192.dtsi b/arch/arm/boot/dts/kirkwood-6192.dtsi
> index dd81508..bed2dec 100644
> --- a/arch/arm/boot/dts/kirkwood-6192.dtsi
> +++ b/arch/arm/boot/dts/kirkwood-6192.dtsi
> @@ -66,6 +66,8 @@
> interrupts = <21>;
> clocks = <&gate_clk 14>, <&gate_clk 15>;
> clock-names = "0", "1";
> + phys = <&sata_phy0>, <&sata_phy1>;
> + phy-names = "port0", "port1";
Please indent with tabs, not spaces.
[...]
WBR, Sergei
Dear Evgeni Dobrev,
On Mon, 15 Dec 2014 21:37:24 +0100, Evgeni Dobrev wrote:
> This patch enables the phy drivers for the SATA controller on Marvell's 88f6192. Without them it is not possible to use SATA drives attached to this processor.
Commit log text should be wrapped to some reasonable length.
> interrupts = <21>;
> clocks = <&gate_clk 14>, <&gate_clk 15>;
> clock-names = "0", "1";
> + phys = <&sata_phy0>, <&sata_phy1>;
> + phy-names = "port0", "port1";
You should use tabs and not spaces for indentation in Device Tree files.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Hello Thomas,
On Tue, Dec 16, 2014 at 05:01:38PM +0100, Thomas Petazzoni wrote:
> Dear Evgeni Dobrev,
>
> On Mon, 15 Dec 2014 21:37:24 +0100, Evgeni Dobrev wrote:
> > This patch enables the phy drivers for the SATA controller on Marvell's 88f6192. Without them it is not possible to use SATA drives attached to this processor.
>
> Commit log text should be wrapped to some reasonable length.
>
I will fix this.
>
> > interrupts = <21>;
> > clocks = <&gate_clk 14>, <&gate_clk 15>;
> > clock-names = "0", "1";
> > + phys = <&sata_phy0>, <&sata_phy1>;
> > + phy-names = "port0", "port1";
>
> You should use tabs and not spaces for indentation in Device Tree files.
I will resubmit. Thank you for your review.
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
> --
evgeni
v2: indent with tabs only
wrap change log at 80 chars
Evgeni Dobrev (1):
enable phy driver for SATA controller on 88f6192
arch/arm/boot/dts/kirkwood-6192.dtsi | 2 ++
1 file changed, 2 insertions(+)
--
1.7.10.4
This patch enables the phy drivers for the SATA controller on Marvell's 88f6192.
Without them it is not possible to use SATA drives attached to this processor.
Signed-off-by: Evgeni Dobrev <[email protected]>
---
arch/arm/boot/dts/kirkwood-6192.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/kirkwood-6192.dtsi b/arch/arm/boot/dts/kirkwood-6192.dtsi
index dd81508..9e6e9e2 100644
--- a/arch/arm/boot/dts/kirkwood-6192.dtsi
+++ b/arch/arm/boot/dts/kirkwood-6192.dtsi
@@ -66,6 +66,8 @@
interrupts = <21>;
clocks = <&gate_clk 14>, <&gate_clk 15>;
clock-names = "0", "1";
+ phys = <&sata_phy0>, <&sata_phy1>;
+ phy-names = "port0", "port1";
status = "disabled";
};
--
1.7.10.4
On Tue, Dec 16, 2014 at 07:22:18PM +0100, Evgeni Dobrev wrote:
> This patch enables the phy drivers for the SATA controller on Marvell's 88f6192.
> Without them it is not possible to use SATA drives attached to this processor.
>
> Signed-off-by: Evgeni Dobrev <[email protected]>
Hi Evgeni
Added to mvebu/dt
Andrew
> ---
> arch/arm/boot/dts/kirkwood-6192.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/kirkwood-6192.dtsi b/arch/arm/boot/dts/kirkwood-6192.dtsi
> index dd81508..9e6e9e2 100644
> --- a/arch/arm/boot/dts/kirkwood-6192.dtsi
> +++ b/arch/arm/boot/dts/kirkwood-6192.dtsi
> @@ -66,6 +66,8 @@
> interrupts = <21>;
> clocks = <&gate_clk 14>, <&gate_clk 15>;
> clock-names = "0", "1";
> + phys = <&sata_phy0>, <&sata_phy1>;
> + phy-names = "port0", "port1";
> status = "disabled";
> };
>
> --
> 1.7.10.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel