2015-02-05 13:38:26

by Lad, Prabhakar

Subject: [PATCH] xen-netback: fix sparse warning

From: "Lad, Prabhakar" <[email protected]>

this patch fixes following sparse warning:

interface.c:83:5: warning: symbol 'xenvif_poll' was not declared. Should it be static?

Signed-off-by: Lad, Prabhakar <[email protected]>
---
Found this issue on linux-next (gcc version 4.9.2,
sparse version 0.4.5-rc1)and applies on top linux-next.

drivers/net/xen-netback/interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
index 12f9e27..f38227a 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -80,7 +80,7 @@ static irqreturn_t xenvif_tx_interrupt(int irq, void *dev_id)
return IRQ_HANDLED;
}

-int xenvif_poll(struct napi_struct *napi, int budget)
+static int xenvif_poll(struct napi_struct *napi, int budget)
{
struct xenvif_queue *queue =
container_of(napi, struct xenvif_queue, napi);
--
1.9.1

2015-02-05 14:01:15

by Wei Liu

Subject: Re: [PATCH] xen-netback: fix sparse warning

On Thu, Feb 05, 2015 at 01:38:07PM +0000, Lad Prabhakar wrote:
> From: "Lad, Prabhakar" <[email protected]>
>
> this patch fixes following sparse warning:
>
> interface.c:83:5: warning: symbol 'xenvif_poll' was not declared. Should it be static?
>
> Signed-off-by: Lad, Prabhakar <[email protected]>

Acked-by: Wei Liu <[email protected]>

Thanks!

> ---
> Found this issue on linux-next (gcc version 4.9.2,
> sparse version 0.4.5-rc1)and applies on top linux-next.
>
> drivers/net/xen-netback/interface.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
> index 12f9e27..f38227a 100644
> --- a/drivers/net/xen-netback/interface.c
> +++ b/drivers/net/xen-netback/interface.c
> @@ -80,7 +80,7 @@ static irqreturn_t xenvif_tx_interrupt(int irq, void *dev_id)
> return IRQ_HANDLED;
> }
>
> -int xenvif_poll(struct napi_struct *napi, int budget)
> +static int xenvif_poll(struct napi_struct *napi, int budget)
> {
> struct xenvif_queue *queue =
> container_of(napi, struct xenvif_queue, napi);
> --
> 1.9.1

2015-02-06 00:04:47

by David Miller

Subject: Re: [PATCH] xen-netback: fix sparse warning

From: Lad Prabhakar <[email protected]>
Date: Thu, 5 Feb 2015 13:38:07 +0000

> From: "Lad, Prabhakar" <[email protected]>
>
> this patch fixes following sparse warning:
>
> interface.c:83:5: warning: symbol 'xenvif_poll' was not declared. Should it be static?
>
> Signed-off-by: Lad, Prabhakar <[email protected]>

Applied.