2015-05-23 13:40:44

by Heiko Stuebner

[permalink] [raw]
Subject: [PATCH] PM / AVS: rockchip-io: depend on CONFIG_POWER_AVS

The rockchip io-domain driver currently only depends on ARCH_ROCKCHIP
itself. This makes it possible to select the power-domain driver, but
not the POWER_AVS class and results in the iodomain-driver not getting
build in this case.

So add the additional dependency, which also results in the driver
config option now being placed nicely into the AVS submenu.

Fixes: 662a958638bd ("PM / AVS: rockchip-io: add driver handling Rockchip io domains")
Signed-off-by: Heiko Stuebner <[email protected]>
---
Found while trying to make the wifi on current rk3288 Chromebooks work.

drivers/power/avs/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/power/avs/Kconfig b/drivers/power/avs/Kconfig
index 7f3d389..a67eeac 100644
--- a/drivers/power/avs/Kconfig
+++ b/drivers/power/avs/Kconfig
@@ -13,7 +13,7 @@ menuconfig POWER_AVS

config ROCKCHIP_IODOMAIN
tristate "Rockchip IO domain support"
- depends on ARCH_ROCKCHIP && OF
+ depends on POWER_AVS && ARCH_ROCKCHIP && OF
help
Say y here to enable support io domains on Rockchip SoCs. It is
necessary for the io domain setting of the SoC to match the
--
2.1.4


2015-05-24 19:55:13

by Sebastian Reichel

[permalink] [raw]
Subject: Re: [PATCH] PM / AVS: rockchip-io: depend on CONFIG_POWER_AVS

Hi,

On Sat, May 23, 2015 at 03:41:30PM +0200, Heiko Stuebner wrote:
> The rockchip io-domain driver currently only depends on ARCH_ROCKCHIP
> itself. This makes it possible to select the power-domain driver, but
> not the POWER_AVS class and results in the iodomain-driver not getting
> build in this case.
>
> So add the additional dependency, which also results in the driver
> config option now being placed nicely into the AVS submenu.
>
> Fixes: 662a958638bd ("PM / AVS: rockchip-io: add driver handling Rockchip io domains")
> Signed-off-by: Heiko Stuebner <[email protected]>

Looks like the power supply entry in the MAINTAINERS file is missing
an "X: drivers/power/avs/" entry.

-- Sebastian


Attachments:
(No filename) (702.00 B)
signature.asc (819.00 B)
Digital signature
Download all attachments

2015-05-26 23:21:40

by Kevin Hilman

[permalink] [raw]
Subject: Re: [PATCH] PM / AVS: rockchip-io: depend on CONFIG_POWER_AVS

Heiko Stuebner <[email protected]> writes:

> The rockchip io-domain driver currently only depends on ARCH_ROCKCHIP
> itself. This makes it possible to select the power-domain driver, but
> not the POWER_AVS class and results in the iodomain-driver not getting
> build in this case.
>
> So add the additional dependency, which also results in the driver
> config option now being placed nicely into the AVS submenu.
>
> Fixes: 662a958638bd ("PM / AVS: rockchip-io: add driver handling Rockchip io domains")
> Signed-off-by: Heiko Stuebner <[email protected]>

Acked-by: Kevin Hilman <[email protected]>

Rafael, feel free to queue this up as a fix. I don't have any other
drivers/power/avs stuff queued up.

Kevin