2015-06-06 09:02:12

by Aparna Karuthodi

[permalink] [raw]

Subject: Re: [PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary for single statement [email protected],

---

On Sat, Jun 06, 2015 at 02:26:28PM +0530, Aparna wrote:

> From 59e894efbd2fc3e85edab2e142f7193b6a238789 Mon Sep 17 00:00:00 2001
> From: Aparna Karuthodi <[email protected]>
> Date: Sat, 6 Jun 2015 11:01:16 +0530
> Subject: [PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary
> for single statement blocks
>
> Removed the braces of if else statements which contain only one
> statement
>
> Signed-off-by: Aparna Karuthodi <[email protected]>
> ---
> drivers/staging/dgnc/dgnc_tty.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
> index f81a375..6cd0b6a 100644
> --- a/drivers/staging/dgnc/dgnc_tty.c
> +++ b/drivers/staging/dgnc/dgnc_tty.c
> @@ -907,7 +907,7 @@ void dgnc_check_queue_flow_control(struct channel_t *ch)
> * 3) NONE - Do nothing. Since we didn't do anything to turn off the
> * other side, we don't need to do anything now.
> */
> - if (qleft > (RQUEUESIZE / 2)) {
> + if (qleft > (RQUEUESIZE / 2))
> /* HWFLOW */
> if (ch->ch_digi.digi_flags & RTSPACE || ch->ch_c_cflag & CRTSCTS) {
> if (ch->ch_flags & CH_RECEIVER_OFF) {
> @@ -921,10 +921,10 @@ void dgnc_check_queue_flow_control(struct channel_t *ch)
> ch->ch_bd->bd_ops->send_start_character(ch);
> }
> /* No FLOW */
> - else {
> + else
> /* Nothing needed. */
> - }
> - }
> +
> +
> }
>
>
> --
> 1.7.9.5
>

---

Attachments:

(No filename) (1.42 kB)
0003-PATCH-staging-dgnc-Fixed-braces-are-not-necessary-fo.patch (1.28 kB)
Download all attachments

2015-06-06 14:35:26

by Dan Carpenter

[permalink] [raw]

Subject: Re: [PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary for single statement [email protected],

---

Send the patch to yourself. Apply it with git am. Review the git log
and then send it to the list.

But actually this change is not correct at all. The prefered style in
staging is that multi-line indent blocks get curly braces for
readability even when they are not required by the compiler. The patch
introduces other coding style violations. Did you run checkpatch.pl
over it?

regards,
dan carpenter