Hi Steve,
On Wed, Jan 28, 2015 at 12:48:55PM +0000, Javi Merino wrote:
> Trace can now generate traces with variable element size arrays. Add
> support to parse them.
>
> Cc: Namhyung Kim <[email protected]>
> Cc: Arnaldo Carvalho de Melo <[email protected]>
> Cc: Steven Rostedt <[email protected]>
> Cc: Jiri Olsa <[email protected]>
> Signed-off-by: Javi Merino <[email protected]>
> ---
> tools/lib/traceevent/event-parse.c | 93 ++++++++++++++++++++++++++++++++++++++
> tools/lib/traceevent/event-parse.h | 8 ++++
> 2 files changed, 101 insertions(+)
I've seen that patch 1 of this series is now in mainline. What about
patches 2 and 3 (the updates to tools/lib/traceevent)? Shall I resend
them?
These two patches should also be applied to trace-cmd. Do you want me
to send patches for that to linux-kernel or will you take care of
applying them there?
Incidentally, why are there two copies of libtraceevent? Shouldn't
this live only in one place (either kernel or trace-cmd)?
Cheers,
Javi
On Fri, 27 Feb 2015 12:32:32 +0000
Javi Merino <[email protected]> wrote:
> Hi Steve,
>
> On Wed, Jan 28, 2015 at 12:48:55PM +0000, Javi Merino wrote:
> > Trace can now generate traces with variable element size arrays. Add
> > support to parse them.
> >
> > Cc: Namhyung Kim <[email protected]>
> > Cc: Arnaldo Carvalho de Melo <[email protected]>
> > Cc: Steven Rostedt <[email protected]>
> > Cc: Jiri Olsa <[email protected]>
> > Signed-off-by: Javi Merino <[email protected]>
> > ---
> > tools/lib/traceevent/event-parse.c | 93 ++++++++++++++++++++++++++++++++++++++
> > tools/lib/traceevent/event-parse.h | 8 ++++
> > 2 files changed, 101 insertions(+)
>
> I've seen that patch 1 of this series is now in mainline. What about
> patches 2 and 3 (the updates to tools/lib/traceevent)? Shall I resend
> them?
Patches 2 and 3 are in tools/lib and need to go through Jiri and
Arnaldo. Please repost them again. I can give them acks.
>
> These two patches should also be applied to trace-cmd. Do you want me
> to send patches for that to linux-kernel or will you take care of
> applying them there?
No need, I can pull them from here. I just been a bit busy to do so.
>
> Incidentally, why are there two copies of libtraceevent? Shouldn't
> this live only in one place (either kernel or trace-cmd)?
Actually, libtraceevent does not exist in trace-cmd, just the event
parsing code. libtraceevent needs to be packaged up and supplied as a
library. That's on our todo list, but never seems to get done :-/
Until libtraceevent is provided by all distros, there will continue to
be duplicate code. And it's not just with these two tools. I can think
of two other tools that also share this code for parsing. It really
does need to get packaged up.
-- Steve
On Fri, Feb 27, 2015 at 02:15:05PM +0000, Steven Rostedt wrote:
> On Fri, 27 Feb 2015 12:32:32 +0000
> Javi Merino <[email protected]> wrote:
>
> > Hi Steve,
> >
> > On Wed, Jan 28, 2015 at 12:48:55PM +0000, Javi Merino wrote:
> > > Trace can now generate traces with variable element size arrays. Add
> > > support to parse them.
> > >
> > > Cc: Namhyung Kim <[email protected]>
> > > Cc: Arnaldo Carvalho de Melo <[email protected]>
> > > Cc: Steven Rostedt <[email protected]>
> > > Cc: Jiri Olsa <[email protected]>
> > > Signed-off-by: Javi Merino <[email protected]>
> > > ---
> > > tools/lib/traceevent/event-parse.c | 93 ++++++++++++++++++++++++++++++++++++++
> > > tools/lib/traceevent/event-parse.h | 8 ++++
> > > 2 files changed, 101 insertions(+)
> >
> > I've seen that patch 1 of this series is now in mainline. What about
> > patches 2 and 3 (the updates to tools/lib/traceevent)? Shall I resend
> > them?
>
> Patches 2 and 3 are in tools/lib and need to go through Jiri and
> Arnaldo. Please repost them again. I can give them acks.
Cool, done.
> > These two patches should also be applied to trace-cmd. Do you want me
> > to send patches for that to linux-kernel or will you take care of
> > applying them there?
>
> No need, I can pull them from here. I just been a bit busy to do so.
No worries. I was just unsure about the process.
> >
> > Incidentally, why are there two copies of libtraceevent? Shouldn't
> > this live only in one place (either kernel or trace-cmd)?
>
> Actually, libtraceevent does not exist in trace-cmd, just the event
> parsing code.
Right, that's what I meant. I was wondering about the duplicated
code.
Thanks,
Javi
Hi Steve,
On Fri, Feb 27, 2015 at 02:15:05PM +0000, Steven Rostedt wrote:
> On Fri, 27 Feb 2015 12:32:32 +0000
> Javi Merino <[email protected]> wrote:
> > On Wed, Jan 28, 2015 at 12:48:55PM +0000, Javi Merino wrote:
> > > Trace can now generate traces with variable element size arrays. Add
> > > support to parse them.
> > >
> > > Cc: Namhyung Kim <[email protected]>
> > > Cc: Arnaldo Carvalho de Melo <[email protected]>
> > > Cc: Steven Rostedt <[email protected]>
> > > Cc: Jiri Olsa <[email protected]>
> > > Signed-off-by: Javi Merino <[email protected]>
> > > ---
> > > tools/lib/traceevent/event-parse.c | 93 ++++++++++++++++++++++++++++++++++++++
> > > tools/lib/traceevent/event-parse.h | 8 ++++
> > > 2 files changed, 101 insertions(+)
> >
> > I've seen that patch 1 of this series is now in mainline. What about
> > patches 2 and 3 (the updates to tools/lib/traceevent)? Shall I resend
> > them?
>
> Patches 2 and 3 are in tools/lib and need to go through Jiri and
> Arnaldo. Please repost them again. I can give them acks.
>
> >
> > These two patches should also be applied to trace-cmd. Do you want me
> > to send patches for that to linux-kernel or will you take care of
> > applying them there?
>
> No need, I can pull them from here. I just been a bit busy to do so.
These two patches (b839e1e846ed ("tools lib traceevent: Add support
for __print_array()") and 929a6bb71aa5 ("tools lib traceevent: Factor
out allocating and processing args")) went in as of 4.1-rc1. Any
estimate of when can we have a trace-cmd that have them?
Thanks,
Javi
On Thu, 4 Jun 2015 15:25:48 +0100
Javi Merino <[email protected]> wrote:
> These two patches (b839e1e846ed ("tools lib traceevent: Add support
> for __print_array()") and 929a6bb71aa5 ("tools lib traceevent: Factor
> out allocating and processing args")) went in as of 4.1-rc1. Any
> estimate of when can we have a trace-cmd that have them?
>
I just came back from some time off, and I'm currently trying to catch
up. I have a bunch of patches in trace-cmd right now that hasn't gone
mainline yet.
I may push them to master, but not for the release yet. I'll try to get
to them this week.
-- Steve
On Thu, 4 Jun 2015 15:25:48 +0100
Javi Merino <[email protected]> wrote:
> These two patches (b839e1e846ed ("tools lib traceevent: Add support
> for __print_array()") and 929a6bb71aa5 ("tools lib traceevent: Factor
> out allocating and processing args")) went in as of 4.1-rc1. Any
> estimate of when can we have a trace-cmd that have them?
I finally got around to syncing trace-cmd with lib/traceevent. I just
pushed it out.
Thanks,
-- Steve
On Mon, Jul 13, 2015 at 05:06:46PM +0100, Steven Rostedt wrote:
> On Thu, 4 Jun 2015 15:25:48 +0100
> Javi Merino <[email protected]> wrote:
>
>
> > These two patches (b839e1e846ed ("tools lib traceevent: Add support
> > for __print_array()") and 929a6bb71aa5 ("tools lib traceevent: Factor
> > out allocating and processing args")) went in as of 4.1-rc1. Any
> > estimate of when can we have a trace-cmd that have them?
>
> I finally got around to syncing trace-cmd with lib/traceevent. I just
> pushed it out.
Good news, thank you!
Javi