2015-06-11 05:55:15

by Vaishali Thakkar

[permalink] [raw]
Subject: [PATCH] Blackfin: Use setup_timer

Use the timer API function setup_timer instead of structure field
assignments to initialize a timer.

A simplified version of the Coccinelle semantic patch that performs
this transformation is as follows:

@change@
expression e1, e2, a;
@@

-init_timer(&e1);
+setup_timer(&e1, a, 0UL);
... when != a = e2
-e1.function = a;

Signed-off-by: Vaishali Thakkar <[email protected]>
---
arch/blackfin/kernel/nmi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/blackfin/kernel/nmi.c b/arch/blackfin/kernel/nmi.c
index 9919d29..64dd717 100644
--- a/arch/blackfin/kernel/nmi.c
+++ b/arch/blackfin/kernel/nmi.c
@@ -179,8 +179,7 @@ static int __init init_nmi_wdt(void)
nmi_wdt_start();
nmi_active = true;

- init_timer(&ntimer);
- ntimer.function = nmi_wdt_timer;
+ setup_timer(&ntimer, nmi_wdt_timer, 0UL);
ntimer.expires = jiffies + NMI_CHECK_TIMEOUT;
add_timer(&ntimer);

--
1.9.1