Macro builtin_platform_driver can be used for builtin drivers
that don't do anything in driver init. This file depends on
Kconfig CONFIG_CORESIGHT_LINKS_AND_SINKS which eventually
depends on CORESIGHT. Both CONFIG_CORESIGHT_LINKS_AND_SINKS and
CORESIGHT are bool. So, use builtin_platform_driver and remove
some boilerplate code.
Also, remove header file init.h as functionality like module_init
and module_exit is now relocated to module.h.
Signed-off-by: Vaishali Thakkar <[email protected]>
Suggested-by: Paul Bolle <[email protected]>
---
Changes since v1:
- As per Mathieu's suggestion, remove the comment and
code of Coccinelle
- Also, add blank line before module_platform_driver
Changes since v2:
- Use builtin_platform_driver instead of
module_platform_driver and change commit log and subject
accordingly.
---
drivers/hwtracing/coresight/coresight-replicator.c | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c
index 7974b7c..963ac19 100644
--- a/drivers/hwtracing/coresight/coresight-replicator.c
+++ b/drivers/hwtracing/coresight/coresight-replicator.c
@@ -12,7 +12,6 @@
#include <linux/kernel.h>
#include <linux/module.h>
-#include <linux/init.h>
#include <linux/device.h>
#include <linux/platform_device.h>
#include <linux/io.h>
@@ -184,17 +183,7 @@ static struct platform_driver replicator_driver = {
},
};
-static int __init replicator_init(void)
-{
- return platform_driver_register(&replicator_driver);
-}
-module_init(replicator_init);
-
-static void __exit replicator_exit(void)
-{
- platform_driver_unregister(&replicator_driver);
-}
-module_exit(replicator_exit);
+builtin_platform_driver(replicator_driver);
MODULE_LICENSE("GPL v2");
MODULE_DESCRIPTION("CoreSight Replicator driver");
--
1.9.1
On 10 July 2015 at 06:38, Vaishali Thakkar <[email protected]> wrote:
> Macro builtin_platform_driver can be used for builtin drivers
> that don't do anything in driver init. This file depends on
> Kconfig CONFIG_CORESIGHT_LINKS_AND_SINKS which eventually
> depends on CORESIGHT. Both CONFIG_CORESIGHT_LINKS_AND_SINKS and
> CORESIGHT are bool. So, use builtin_platform_driver and remove
> some boilerplate code.
>
> Also, remove header file init.h as functionality like module_init
> and module_exit is now relocated to module.h.
>
> Signed-off-by: Vaishali Thakkar <[email protected]>
> Suggested-by: Paul Bolle <[email protected]>
> ---
> Changes since v1:
> - As per Mathieu's suggestion, remove the comment and
> code of Coccinelle
> - Also, add blank line before module_platform_driver
> Changes since v2:
> - Use builtin_platform_driver instead of
> module_platform_driver and change commit log and subject
> accordingly.
> ---
> drivers/hwtracing/coresight/coresight-replicator.c | 13 +------------
> 1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c
> index 7974b7c..963ac19 100644
> --- a/drivers/hwtracing/coresight/coresight-replicator.c
> +++ b/drivers/hwtracing/coresight/coresight-replicator.c
> @@ -12,7 +12,6 @@
>
> #include <linux/kernel.h>
> #include <linux/module.h>
> -#include <linux/init.h>
> #include <linux/device.h>
> #include <linux/platform_device.h>
> #include <linux/io.h>
> @@ -184,17 +183,7 @@ static struct platform_driver replicator_driver = {
> },
> };
>
> -static int __init replicator_init(void)
> -{
> - return platform_driver_register(&replicator_driver);
> -}
> -module_init(replicator_init);
> -
> -static void __exit replicator_exit(void)
> -{
> - platform_driver_unregister(&replicator_driver);
> -}
> -module_exit(replicator_exit);
> +builtin_platform_driver(replicator_driver);
>
> MODULE_LICENSE("GPL v2");
> MODULE_DESCRIPTION("CoreSight Replicator driver");
> --
> 1.9.1
>
Applied, thanks.