Since linux/export.h and lib/rbtree.c are not listed in MANIFEST,
`make build-test` always fails as below (Note, to get these messages,
I've removed /dev/null redirect in tests/perf-targz-src-pkg);
----
CC util/hweight.o
../../lib/hweight.c:1:26: fatal error: linux/export.h:
No such file or directory
#include <linux/export.h>
^
compilation terminated.
make[3]: *** [util/hweight.o] Error 1
----
----
GEN common-cmds.h
make[1]: *** No rule to make target `../../lib/rbtree.c',
needed by `python/perf.so'. Stop.
make[1]: *** Waiting for unfinished jobs....
----
Signed-off-by: Masami Hiramatsu <[email protected]>
---
tools/perf/MANIFEST | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/perf/MANIFEST b/tools/perf/MANIFEST
index 09dc0aa..adce9de 100644
--- a/tools/perf/MANIFEST
+++ b/tools/perf/MANIFEST
@@ -58,7 +58,9 @@ include/linux/list.h
include/linux/hash.h
include/linux/stringify.h
lib/hweight.c
+lib/rbtree.c
include/linux/swab.h
+include/linux/export.h
arch/*/include/asm/unistd*.h
arch/*/include/uapi/asm/unistd*.h
arch/*/include/uapi/asm/perf_regs.h
Em Wed, Jul 15, 2015 at 03:07:18PM +0900, Masami Hiramatsu escreveu:
> Since linux/export.h and lib/rbtree.c are not listed in MANIFEST,
> `make build-test` always fails as below (Note, to get these messages,
> I've removed /dev/null redirect in tests/perf-targz-src-pkg);
See:
https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?h=perf/urgent&id=4756e1966c4e1c00a2c6e379cea0322429d1a29b
https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?h=perf/urgent&id=0aefc3590afcc9ecbe173fc01fccbda0869d2f0a
Summary: The fix below is wrong, the right one was pushed to Ingo and
should make its way to Linus soon,
- Arnaldo
> ----
> CC util/hweight.o
> ../../lib/hweight.c:1:26: fatal error: linux/export.h:
> No such file or directory
> #include <linux/export.h>
> ^
> compilation terminated.
> make[3]: *** [util/hweight.o] Error 1
> ----
>
> ----
> GEN common-cmds.h
> make[1]: *** No rule to make target `../../lib/rbtree.c',
> needed by `python/perf.so'. Stop.
> make[1]: *** Waiting for unfinished jobs....
> ----
>
> Signed-off-by: Masami Hiramatsu <[email protected]>
> ---
> tools/perf/MANIFEST | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/MANIFEST b/tools/perf/MANIFEST
> index 09dc0aa..adce9de 100644
> --- a/tools/perf/MANIFEST
> +++ b/tools/perf/MANIFEST
> @@ -58,7 +58,9 @@ include/linux/list.h
> include/linux/hash.h
> include/linux/stringify.h
> lib/hweight.c
> +lib/rbtree.c
> include/linux/swab.h
> +include/linux/export.h
> arch/*/include/asm/unistd*.h
> arch/*/include/uapi/asm/unistd*.h
> arch/*/include/uapi/asm/perf_regs.h
>
On 2015/07/15 20:22, Arnaldo Carvalho de Melo wrote:
> Em Wed, Jul 15, 2015 at 03:07:18PM +0900, Masami Hiramatsu escreveu:
>> Since linux/export.h and lib/rbtree.c are not listed in MANIFEST,
>> `make build-test` always fails as below (Note, to get these messages,
>> I've removed /dev/null redirect in tests/perf-targz-src-pkg);
>
> See:
>
> https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?h=perf/urgent&id=4756e1966c4e1c00a2c6e379cea0322429d1a29b
> https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?h=perf/urgent&id=0aefc3590afcc9ecbe173fc01fccbda0869d2f0a
>
> Summary: The fix below is wrong, the right one was pushed to Ingo and
> should make its way to Linus soon,
Ah, OK.
Since I just noticed that when I ran "make build-test" before releasing
my patchset of perf probe cache. If it has successfully gone, please
ignore this :)
Thank you!
>
> - Arnaldo
>
>> ----
>> CC util/hweight.o
>> ../../lib/hweight.c:1:26: fatal error: linux/export.h:
>> No such file or directory
>> #include <linux/export.h>
>> ^
>> compilation terminated.
>> make[3]: *** [util/hweight.o] Error 1
>> ----
>>
>> ----
>> GEN common-cmds.h
>> make[1]: *** No rule to make target `../../lib/rbtree.c',
>> needed by `python/perf.so'. Stop.
>> make[1]: *** Waiting for unfinished jobs....
>> ----
>>
>> Signed-off-by: Masami Hiramatsu <[email protected]>
>> ---
>> tools/perf/MANIFEST | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/tools/perf/MANIFEST b/tools/perf/MANIFEST
>> index 09dc0aa..adce9de 100644
>> --- a/tools/perf/MANIFEST
>> +++ b/tools/perf/MANIFEST
>> @@ -58,7 +58,9 @@ include/linux/list.h
>> include/linux/hash.h
>> include/linux/stringify.h
>> lib/hweight.c
>> +lib/rbtree.c
>> include/linux/swab.h
>> +include/linux/export.h
>> arch/*/include/asm/unistd*.h
>> arch/*/include/uapi/asm/unistd*.h
>> arch/*/include/uapi/asm/perf_regs.h
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
Masami HIRAMATSU
Linux Technology Research Center, System Productivity Research Dept.
Center for Technology Innovation - Systems Engineering
Hitachi, Ltd., Research & Development Group
E-mail: [email protected]
Em Wed, Jul 15, 2015 at 10:51:27PM +0900, Masami Hiramatsu escreveu:
> On 2015/07/15 20:22, Arnaldo Carvalho de Melo wrote:
> > https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?h=perf/urgent&id=4756e1966c4e1c00a2c6e379cea0322429d1a29b
> > https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?h=perf/urgent&id=0aefc3590afcc9ecbe173fc01fccbda0869d2f0a
> >
> > Summary: The fix below is wrong, the right one was pushed to Ingo and
> > should make its way to Linus soon,
>
> Ah, OK.
> Since I just noticed that when I ran "make build-test" before releasing
> my patchset of perf probe cache. If it has successfully gone, please
> ignore this :)
Right, thank you for doing that, in this case I was the bad boy, guess I
need to make those tests run in parallel...
Thanks!
- Arnaldo