2015-07-21 08:41:21

by Lukasz Anaczkowski

Subject: [PATCH] intel_pstate: Add get_scaling cpu_defaults param to Knights Landing

Scaling for Knights Landing is same as the default scaling (100000).
When Knigts Landing support was added to the pstate driver, this
parameter was omitted resulting in a kernel panic during boot.

Reported-by: Yasuaki Ishimatsu <[email protected]>
Signed-off-by: Dasaratharaman Chandramouli <[email protected]>
Signed-off-by: Lukasz Anaczkowski <[email protected]>
---
drivers/cpufreq/intel_pstate.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index 15ada47..fcb929e 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -681,6 +681,7 @@ static struct cpu_defaults knl_params = {
.get_max = core_get_max_pstate,
.get_min = core_get_min_pstate,
.get_turbo = knl_get_turbo_pstate,
+ .get_scaling = core_get_scaling,
.set = core_set_pstate,
},
};
--
1.8.3.1

2015-07-21 20:12:06

by Kristen Carlson Accardi

Subject: Re: [PATCH] intel_pstate: Add get_scaling cpu_defaults param to Knights Landing

On Tue, 21 Jul 2015 10:41:13 +0200
Lukasz Anaczkowski <[email protected]> wrote:

> Scaling for Knights Landing is same as the default scaling (100000).
> When Knigts Landing support was added to the pstate driver, this
> parameter was omitted resulting in a kernel panic during boot.
>
> Reported-by: Yasuaki Ishimatsu <[email protected]>
> Signed-off-by: Dasaratharaman Chandramouli <[email protected]>
> Signed-off-by: Lukasz Anaczkowski <[email protected]>
> ---
> drivers/cpufreq/intel_pstate.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index 15ada47..fcb929e 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -681,6 +681,7 @@ static struct cpu_defaults knl_params = {
> .get_max = core_get_max_pstate,
> .get_min = core_get_min_pstate,
> .get_turbo = knl_get_turbo_pstate,
> + .get_scaling = core_get_scaling,
> .set = core_set_pstate,
> },
> };

Acked-by: Kristen Carlson Accardi <[email protected]>

2015-07-23 20:34:27

by Rafael J. Wysocki

Subject: Re: [PATCH] intel_pstate: Add get_scaling cpu_defaults param to Knights Landing

On Tuesday, July 21, 2015 10:41:13 AM Lukasz Anaczkowski wrote:
> Scaling for Knights Landing is same as the default scaling (100000).
> When Knigts Landing support was added to the pstate driver, this
> parameter was omitted resulting in a kernel panic during boot.
>
> Reported-by: Yasuaki Ishimatsu <[email protected]>
> Signed-off-by: Dasaratharaman Chandramouli <[email protected]>
> Signed-off-by: Lukasz Anaczkowski <[email protected]>

Queued up for 4.3, thanks!

> ---
> drivers/cpufreq/intel_pstate.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index 15ada47..fcb929e 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -681,6 +681,7 @@ static struct cpu_defaults knl_params = {
> .get_max = core_get_max_pstate,
> .get_min = core_get_min_pstate,
> .get_turbo = knl_get_turbo_pstate,
> + .get_scaling = core_get_scaling,
> .set = core_set_pstate,
> },
> };
>

--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.