2015-08-23 13:01:57

by Alexandru Moise

Subject: [PATCH] btrfs: Fixed dsize and last_off declarations

The return values of btrfs_item_offset_nr and btrfs_item_size_nr are of
type u32. To avoid mixing signed and unsigned integers we should also
declare dsize and last_off to be of type u32.

Signed-off-by: Alexandru Moise <[email protected]>
---
fs/btrfs/ctree.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
index 54114b4..4ff739e 100644
--- a/fs/btrfs/ctree.c
+++ b/fs/btrfs/ctree.c
@@ -4938,8 +4938,8 @@ int btrfs_del_items(struct btrfs_trans_handle *trans, struct btrfs_root *root,
{
struct extent_buffer *leaf;
struct btrfs_item *item;
- int last_off;
- int dsize = 0;
+ u32 last_off;
+ u32 dsize = 0;
int ret = 0;
int wret;
int i;
--
2.5.0

2015-08-27 11:51:45

by David Sterba

Subject: Re: [PATCH] btrfs: Fixed dsize and last_off declarations

On Sun, Aug 23, 2015 at 04:01:42PM +0000, Alexandru Moise wrote:
> The return values of btrfs_item_offset_nr and btrfs_item_size_nr are of
> type u32. To avoid mixing signed and unsigned integers we should also
> declare dsize and last_off to be of type u32.
>
> Signed-off-by: Alexandru Moise <[email protected]>

Reviewed-by: David Sterba <[email protected]>