2015-12-07 17:22:07

by Bjørn Mork

[permalink] [raw]
Subject: Re: [PATCH 4.1 03/95] qmi_wwan: add Sierra Wireless MC74xx/EM74xx

Greg Kroah-Hartman <[email protected]> writes:

> 4.1-stable review patch. If anyone has any objections, please let me know.
>
> ------------------
>
> From: =?UTF-8?q?Bj=C3=B8rn=20Mork?= <[email protected]>
>
> [ Upstream commit 0db65fcfcded76fe4f74e3ca9f4e2baf67b683ef ]
>
> New device IDs shamelessly lifted from the vendor driver.
>
> Signed-off-by: BjÞrn Mork <[email protected]>
> Signed-off-by: David S. Miller <[email protected]>
> Signed-off-by: Greg Kroah-Hartman <[email protected]>
> ---
> drivers/net/usb/qmi_wwan.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -764,6 +764,10 @@ static const struct usb_device_id produc
> {QMI_FIXED_INTF(0x1199, 0x9056, 8)}, /* Sierra Wireless Modem */
> {QMI_FIXED_INTF(0x1199, 0x9057, 8)},
> {QMI_FIXED_INTF(0x1199, 0x9061, 8)}, /* Sierra Wireless Modem */
> + {QMI_FIXED_INTF(0x1199, 0x9070, 8)}, /* Sierra Wireless MC74xx/EM74xx */
> + {QMI_FIXED_INTF(0x1199, 0x9070, 10)}, /* Sierra Wireless MC74xx/EM74xx */
> + {QMI_FIXED_INTF(0x1199, 0x9071, 8)}, /* Sierra Wireless MC74xx/EM74xx */
> + {QMI_FIXED_INTF(0x1199, 0x9071, 10)}, /* Sierra Wireless MC74xx/EM74xx */
> {QMI_FIXED_INTF(0x1bbb, 0x011e, 4)}, /* Telekom Speedstick LTE II (Alcatel One Touch L100V LTE) */
> {QMI_FIXED_INTF(0x1bbb, 0x0203, 2)}, /* Alcatel L800MA */
> {QMI_FIXED_INTF(0x2357, 0x0201, 4)}, /* TP-LINK HSUPA Modem MA180 */

This will of course not harm, but I later found out that the driver
needed more substantial changes to fully support this modem. Those
changes will be in v4.5 but are unsuitable for stable.

Maybe drop to avoid unnecessary confusion? If so, then the 4.2 and 4.3
versions should be dropped as well.


Bjørn


2015-12-09 03:28:25

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 4.1 03/95] qmi_wwan: add Sierra Wireless MC74xx/EM74xx

On Mon, Dec 07, 2015 at 06:21:56PM +0100, Bjørn Mork wrote:
> Greg Kroah-Hartman <[email protected]> writes:
>
> > 4.1-stable review patch. If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: =?UTF-8?q?Bj=C3=B8rn=20Mork?= <[email protected]>
> >
> > [ Upstream commit 0db65fcfcded76fe4f74e3ca9f4e2baf67b683ef ]
> >
> > New device IDs shamelessly lifted from the vendor driver.
> >
> > Signed-off-by: BjÞrn Mork <[email protected]>
> > Signed-off-by: David S. Miller <[email protected]>
> > Signed-off-by: Greg Kroah-Hartman <[email protected]>
> > ---
> > drivers/net/usb/qmi_wwan.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > --- a/drivers/net/usb/qmi_wwan.c
> > +++ b/drivers/net/usb/qmi_wwan.c
> > @@ -764,6 +764,10 @@ static const struct usb_device_id produc
> > {QMI_FIXED_INTF(0x1199, 0x9056, 8)}, /* Sierra Wireless Modem */
> > {QMI_FIXED_INTF(0x1199, 0x9057, 8)},
> > {QMI_FIXED_INTF(0x1199, 0x9061, 8)}, /* Sierra Wireless Modem */
> > + {QMI_FIXED_INTF(0x1199, 0x9070, 8)}, /* Sierra Wireless MC74xx/EM74xx */
> > + {QMI_FIXED_INTF(0x1199, 0x9070, 10)}, /* Sierra Wireless MC74xx/EM74xx */
> > + {QMI_FIXED_INTF(0x1199, 0x9071, 8)}, /* Sierra Wireless MC74xx/EM74xx */
> > + {QMI_FIXED_INTF(0x1199, 0x9071, 10)}, /* Sierra Wireless MC74xx/EM74xx */
> > {QMI_FIXED_INTF(0x1bbb, 0x011e, 4)}, /* Telekom Speedstick LTE II (Alcatel One Touch L100V LTE) */
> > {QMI_FIXED_INTF(0x1bbb, 0x0203, 2)}, /* Alcatel L800MA */
> > {QMI_FIXED_INTF(0x2357, 0x0201, 4)}, /* TP-LINK HSUPA Modem MA180 */
>
> This will of course not harm, but I later found out that the driver
> needed more substantial changes to fully support this modem. Those
> changes will be in v4.5 but are unsuitable for stable.
>
> Maybe drop to avoid unnecessary confusion? If so, then the 4.2 and 4.3
> versions should be dropped as well.

Thanks for letting me know, I've dropped it from all of the trees.

greg k-h