2016-10-05 20:33:51

by Jitendra

Subject: [PATCH] staging: speakup: Replaced obsolete simple_strtoul

From: Jitendra Kumar Khasdev <[email protected]>

This patch is for replacing obsolete simple_strtoul to kstrtoul which remove warning produce by checkpatch.

Signed-off-by: Jitendra Kumar Khasdev <[email protected]>
---
drivers/staging/speakup/varhandlers.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/speakup/varhandlers.c b/drivers/staging/speakup/varhandlers.c
index 21186e3..1a3caf3 100644
--- a/drivers/staging/speakup/varhandlers.c
+++ b/drivers/staging/speakup/varhandlers.c
@@ -323,9 +323,11 @@ char *spk_strlwr(char *s)

char *spk_s2uchar(char *start, char *dest)
{
- int val;
+ unsigned long val;
+
+ if (kstrtoul(start, 10, &val))
+ return NULL;

- val = simple_strtoul(skip_spaces(start), &start, 10);
if (*start == ',')
start++;
*dest = (u_char)val;
--
2.7.4

2016-10-05 21:11:16

by Samuel Thibault

Subject: Re: [PATCH] staging: speakup: Replaced obsolete simple_strtoul

Hello,

Jitendra Khasdev, on Thu 06 Oct 2016 02:02:58 +0530, wrote:
> From: Jitendra Kumar Khasdev <[email protected]>
>
> This patch is for replacing obsolete simple_strtoul to kstrtoul which remove warning produce by checkpatch.

> + unsigned long val;
> +
> + if (kstrtoul(start, 10, &val))
> + return NULL;
>
> - val = simple_strtoul(skip_spaces(start), &start, 10);
> if (*start == ',')

simple_strtoul modifies start, so you can't just replace it with
kstrtoul.

Samuel