2016-11-05 14:26:22

by Heinrich Schuchardt

Subject: [PATCH 1/1] pinctrl: st: st_pinconf_dbg_show wrong format string

function is defined as unsigned int.
So we need %u to print it.

Signed-off-by: Heinrich Schuchardt <[email protected]>
---
drivers/pinctrl/pinctrl-st.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
index b7bb371..8308f15 100644
--- a/drivers/pinctrl/pinctrl-st.c
+++ b/drivers/pinctrl/pinctrl-st.c
@@ -1006,7 +1006,7 @@ static void st_pinconf_dbg_show(struct pinctrl_dev *pctldev,

function = st_pctl_get_pin_function(pc, offset);
if (function)
- snprintf(f, 10, "Alt Fn %d", function);
+ snprintf(f, 10, "Alt Fn %u", function);
else
snprintf(f, 5, "GPIO");

--
2.10.1

2016-11-07 09:03:26

by Patrice CHOTARD

Subject: Re: [PATCH 1/1] pinctrl: st: st_pinconf_dbg_show wrong format string

On 11/05/2016 03:25 PM, Heinrich Schuchardt wrote:
> function is defined as unsigned int.
> So we need %u to print it.
>
> Signed-off-by: Heinrich Schuchardt <[email protected]>
> ---
> drivers/pinctrl/pinctrl-st.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index b7bb371..8308f15 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -1006,7 +1006,7 @@ static void st_pinconf_dbg_show(struct pinctrl_dev *pctldev,
>
> function = st_pctl_get_pin_function(pc, offset);
> if (function)
> - snprintf(f, 10, "Alt Fn %d", function);
> + snprintf(f, 10, "Alt Fn %u", function);
> else
> snprintf(f, 5, "GPIO");
>
>


Hi Heinrich

Acked-by: Patrice Chotard <[email protected]>

Thanks

2016-11-08 10:26:38

by Linus Walleij

Subject: Re: [PATCH 1/1] pinctrl: st: st_pinconf_dbg_show wrong format string

On Sat, Nov 5, 2016 at 3:25 PM, Heinrich Schuchardt <[email protected]> wrote:

> function is defined as unsigned int.
> So we need %u to print it.
>
> Signed-off-by: Heinrich Schuchardt <[email protected]>

Patch applied with Patrice's ACK.

Yours,
Linus Walleij