2017-04-06 20:16:34

by David Rientjes

Subject: [patch] mm, swap_cgroup: reschedule when neeed in swap_cgroup_swapoff()

We got need_resched() warnings in swap_cgroup_swapoff() because
swap_cgroup_ctrl[type].length is particularly large.

Reschedule when needed.

Signed-off-by: David Rientjes <[email protected]>
---
mm/swap_cgroup.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/mm/swap_cgroup.c b/mm/swap_cgroup.c
--- a/mm/swap_cgroup.c
+++ b/mm/swap_cgroup.c
@@ -201,6 +201,8 @@ void swap_cgroup_swapoff(int type)
struct page *page = map[i];
if (page)
__free_page(page);
+ if (!(i % SWAP_CLUSTER_MAX))
+ cond_resched();
}
vfree(map);
}

2017-04-07 08:00:24

by Michal Hocko

Subject: Re: [patch] mm, swap_cgroup: reschedule when neeed in swap_cgroup_swapoff()

On Thu 06-04-17 13:16:24, David Rientjes wrote:
> We got need_resched() warnings in swap_cgroup_swapoff() because
> swap_cgroup_ctrl[type].length is particularly large.
>
> Reschedule when needed.
>
> Signed-off-by: David Rientjes <[email protected]>

Acked-by: Michal Hocko <[email protected]>

> ---
> mm/swap_cgroup.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/mm/swap_cgroup.c b/mm/swap_cgroup.c
> --- a/mm/swap_cgroup.c
> +++ b/mm/swap_cgroup.c
> @@ -201,6 +201,8 @@ void swap_cgroup_swapoff(int type)
> struct page *page = map[i];
> if (page)
> __free_page(page);
> + if (!(i % SWAP_CLUSTER_MAX))
> + cond_resched();
> }
> vfree(map);
> }
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to [email protected]. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

--
Michal Hocko
SUSE Labs

2017-04-10 14:19:07

by Johannes Weiner

Subject: Re: [patch] mm, swap_cgroup: reschedule when neeed in swap_cgroup_swapoff()

On Thu, Apr 06, 2017 at 01:16:24PM -0700, David Rientjes wrote:
> We got need_resched() warnings in swap_cgroup_swapoff() because
> swap_cgroup_ctrl[type].length is particularly large.
>
> Reschedule when needed.
>
> Signed-off-by: David Rientjes <[email protected]>

Acked-by: Johannes Weiner <[email protected]>