2017-06-29 09:37:31

by Bhumika Goyal

Subject: [PATCH] tee: optee: add const to tee_driver_ops and tee_desc structures

Add const to tee_desc structures as they are only passed as an argument
to the function tee_device_alloc. This argument is of type const, so
declare these structures as const too.
Add const to tee_driver_ops structures as they are only stored in the
ops field of a tee_desc structure. This field is of type const, so
declare these structure types as const.

Signed-off-by: Bhumika Goyal <[email protected]>
---
drivers/tee/optee/core.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c
index 58169e5..7609ec6 100644
--- a/drivers/tee/optee/core.c
+++ b/drivers/tee/optee/core.c
@@ -258,7 +258,7 @@ static void optee_release(struct tee_context *ctx)
}
}

-static struct tee_driver_ops optee_ops = {
+static const struct tee_driver_ops optee_ops = {
.get_version = optee_get_version,
.open = optee_open,
.release = optee_release,
@@ -268,13 +268,13 @@ static struct tee_driver_ops optee_ops = {
.cancel_req = optee_cancel_req,
};

-static struct tee_desc optee_desc = {
+static const struct tee_desc optee_desc = {
.name = DRIVER_NAME "-clnt",
.ops = &optee_ops,
.owner = THIS_MODULE,
};

-static struct tee_driver_ops optee_supp_ops = {
+static const struct tee_driver_ops optee_supp_ops = {
.get_version = optee_get_version,
.open = optee_open,
.release = optee_release,
@@ -282,7 +282,7 @@ static struct tee_driver_ops optee_supp_ops = {
.supp_send = optee_supp_send,
};

-static struct tee_desc optee_supp_desc = {
+static const struct tee_desc optee_supp_desc = {
.name = DRIVER_NAME "-supp",
.ops = &optee_supp_ops,
.owner = THIS_MODULE,
--
2.7.4

2017-07-05 06:57:42

by Jens Wiklander

Subject: Re: [PATCH] tee: optee: add const to tee_driver_ops and tee_desc structures

On Thu, Jun 29, 2017 at 03:05:04PM +0530, Bhumika Goyal wrote:
> Add const to tee_desc structures as they are only passed as an argument
> to the function tee_device_alloc. This argument is of type const, so
> declare these structures as const too.
> Add const to tee_driver_ops structures as they are only stored in the
> ops field of a tee_desc structure. This field is of type const, so
> declare these structure types as const.
>
> Signed-off-by: Bhumika Goyal <[email protected]>

Looks good to me, queueing this.

Thanks,
Jens