2017-08-02 08:43:08

by Anshuman Khandual

Subject: [PATCH] sched/autogroup: Fix error reporting inside autogroup_create()

Its kzalloc() not kmalloc() which has failed earlier. While here
remove a redundant empty line.

Signed-off-by: Anshuman Khandual <[email protected]>
---
kernel/sched/autogroup.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/kernel/sched/autogroup.c b/kernel/sched/autogroup.c
index da39489..de6d7f4 100644
--- a/kernel/sched/autogroup.c
+++ b/kernel/sched/autogroup.c
@@ -71,7 +71,6 @@ static inline struct autogroup *autogroup_create(void)
goto out_fail;

tg = sched_create_group(&root_task_group);
-
if (IS_ERR(tg))
goto out_free;

@@ -101,7 +100,7 @@ static inline struct autogroup *autogroup_create(void)
out_fail:
if (printk_ratelimit()) {
printk(KERN_WARNING "autogroup_create: %s failure.\n",
- ag ? "sched_create_group()" : "kmalloc()");
+ ag ? "sched_create_group()" : "kzalloc()");
}

return autogroup_kref_get(&autogroup_default);
--
1.8.5.2

2017-08-10 16:43:53

by tip-bot for Vasyl Gomonovych

Subject: [tip:sched/core] sched/autogroup: Fix error reporting printk text in autogroup_create()

Commit-ID: 1e58565e6d147751d85ee9e692d1226059b3318f
Gitweb: http://git.kernel.org/tip/1e58565e6d147751d85ee9e692d1226059b3318f
Author: Anshuman Khandual <[email protected]>
AuthorDate: Wed, 2 Aug 2017 14:13:00 +0530
Committer: Ingo Molnar <[email protected]>
CommitDate: Thu, 10 Aug 2017 17:06:03 +0200

sched/autogroup: Fix error reporting printk text in autogroup_create()

Its kzalloc() not kmalloc() which has failed earlier. While here
remove a redundant empty line.

Signed-off-by: Anshuman Khandual <[email protected]>
Cc: Linus Torvalds <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: [email protected]
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Ingo Molnar <[email protected]>
---
kernel/sched/autogroup.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/kernel/sched/autogroup.c b/kernel/sched/autogroup.c
index da39489..de6d7f4 100644
--- a/kernel/sched/autogroup.c
+++ b/kernel/sched/autogroup.c
@@ -71,7 +71,6 @@ static inline struct autogroup *autogroup_create(void)
goto out_fail;

tg = sched_create_group(&root_task_group);
-
if (IS_ERR(tg))
goto out_free;

@@ -101,7 +100,7 @@ out_free:
out_fail:
if (printk_ratelimit()) {
printk(KERN_WARNING "autogroup_create: %s failure.\n",
- ag ? "sched_create_group()" : "kmalloc()");
+ ag ? "sched_create_group()" : "kzalloc()");
}

return autogroup_kref_get(&autogroup_default);