2017-09-05 15:03:54

by Colin King

Subject: [PATCH] clk: cdce925: remove redundant check for non-null parent_name

From: Colin Ian King <[email protected]>

The check for a non-null parent_name is always true as there is an
earlier check for a null parent_name that returns -ENODEV. Remove this
redundant check and always set init.num_parents to 1.

Detected by CoverityScan CID#1309477 ("Logically dead code")

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/clk/clk-cdce925.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clk-cdce925.c b/drivers/clk/clk-cdce925.c
index c933be01c7db..0a7e7d5a7506 100644
--- a/drivers/clk/clk-cdce925.c
+++ b/drivers/clk/clk-cdce925.c
@@ -665,7 +665,7 @@ static int cdce925_probe(struct i2c_client *client,
init.ops = &cdce925_pll_ops;
init.flags = 0;
init.parent_names = &parent_name;
- init.num_parents = parent_name ? 1 : 0;
+ init.num_parents = 1;

/* Register PLL clocks */
for (i = 0; i < data->chip_info->num_plls; ++i) {
--
2.14.1

2017-11-14 01:58:17

by Stephen Boyd

Subject: Re: [PATCH] clk: cdce925: remove redundant check for non-null parent_name

On 09/05, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The check for a non-null parent_name is always true as there is an
> earlier check for a null parent_name that returns -ENODEV. Remove this
> redundant check and always set init.num_parents to 1.
>
> Detected by CoverityScan CID#1309477 ("Logically dead code")
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---

Applied to clk-next

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

From 1577712488456579238@xxx Tue Sep 05 15:04:38 +0000 2017
X-GM-THRID: 1577712488456579238
X-Gmail-Labels: Inbox,Category Forums