2017-09-15 19:54:12

by Arnd Bergmann

[permalink] [raw]
Subject: [PATCH] clk: pxa: fix building on older compilers

gcc-4.4 got confused by the inline assembler statement:

drivers/clk/pxa/clk-pxa.c: In function 'pxa2xx_core_turbo_switch':
drivers/clk/pxa/clk-pxa.c:152: error: expected string literal before ')' token

This removes the extraneous ':' to let all compilers parse the
driver correctly.

Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/clk/pxa/clk-pxa.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/clk/pxa/clk-pxa.c b/drivers/clk/pxa/clk-pxa.c
index 74f64c3c4290..b80dc9d5855c 100644
--- a/drivers/clk/pxa/clk-pxa.c
+++ b/drivers/clk/pxa/clk-pxa.c
@@ -147,9 +147,7 @@ void pxa2xx_core_turbo_switch(bool on)
" b 3f\n"
"2: b 1b\n"
"3: nop\n"
- : "=&r" (unused)
- : "r" (clkcfg)
- : );
+ : "=&r" (unused) : "r" (clkcfg));

local_irq_restore(flags);
}
--
2.9.0


2017-09-19 18:46:54

by Robert Jarzmik

[permalink] [raw]
Subject: Re: [PATCH] clk: pxa: fix building on older compilers

Arnd Bergmann <[email protected]> writes:

> gcc-4.4 got confused by the inline assembler statement:
>
> drivers/clk/pxa/clk-pxa.c: In function 'pxa2xx_core_turbo_switch':
> drivers/clk/pxa/clk-pxa.c:152: error: expected string literal before ')' token
>
> This removes the extraneous ':' to let all compilers parse the
> driver correctly.
>
> Signed-off-by: Arnd Bergmann <[email protected]>
Acked-by: Robert Jarzmik <[email protected]>

Cheers.

--
Robert

2017-11-15 00:14:42

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH] clk: pxa: fix building on older compilers

On 09/15, Arnd Bergmann wrote:
> gcc-4.4 got confused by the inline assembler statement:
>
> drivers/clk/pxa/clk-pxa.c: In function 'pxa2xx_core_turbo_switch':
> drivers/clk/pxa/clk-pxa.c:152: error: expected string literal before ')' token
>
> This removes the extraneous ':' to let all compilers parse the
> driver correctly.
>
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---

Applied to clk-next

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

From 1578994914174591033@xxx Tue Sep 19 18:48:15 +0000 2017
X-GM-THRID: 1578636710395638450
X-Gmail-Labels: Inbox,Category Forums