2017-11-28 10:37:19

by Stefan Hajnoczi

[permalink] [raw]
Subject: Re: [PATCH] VSOCK: Don't set sk_state to TCP_CLOSE before testing it

On Mon, Nov 27, 2017 at 05:29:32AM -0800, Jorgen Hansen wrote:
> A recent commit (3b4477d2dcf2) converted the sk_state to use
> TCP constants. In that change, vmci_transport_handle_detach
> was changed such that sk->sk_state was set to TCP_CLOSE before
> we test whether it is TCP_SYN_SENT. This change moves the
> sk_state change back to the original locations in that function.
>
> Signed-off-by: Jorgen Hansen <[email protected]>
> ---
> net/vmw_vsock/vmci_transport.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Sorry, silly bug on my part!

Reviewed-by: Stefan Hajnoczi <[email protected]>


Attachments:
(No filename) (632.00 B)
signature.asc (465.00 B)
Download all attachments