2017-11-28 12:15:02

by Chris Coffey

[permalink] [raw]
Subject: Re: [PATCH] staging: most: Fix build errors

On Tue, Nov 28, 2017 at 08:26:07AM +0100, Greg Kroah-Hartman wrote:
> On Mon, Nov 27, 2017 at 09:12:39PM +0000, Chris Coffey wrote:
> > This patch fixes build errors that occur when trying to build the
> > MOST modules. For example, the cdev module build fails with:
> >
> > make[3]: *** No rule to make target 'drivers/staging/most/aim-cdev/cdev.o', needed by 'drivers/staging/most/aim-cdev/aim_cdev.o'. Stop.
> > scripts/Makefile.build:569: recipe for target 'drivers/staging/most/aim-cdev' failed
> > make[2]: *** [drivers/staging/most/aim-cdev] Error 2
> > scripts/Makefile.build:569: recipe for target 'drivers/staging/most' failed
> > make[1]: *** [drivers/staging/most] Error 2
> > Makefile:1502: recipe for target '_module_drivers/staging' failed
> > make: *** [_module_drivers/staging] Error 2
>
> How are you seeing this error? What is the build command line that you
> provided to do this? It should just "not build" right now at all.
>

I did a git pull to get the latest staging updates, enabled a bunch of
staging drivers, and then ran a build on the staging modules with 'make
modules M=drivers/staging'. Unfortunately now I'm unable to reproduce
the error (of course).

> > Update the Makefile variables and paths with the new directory
> > structure to fix these errors.
> >
> > Signed-off-by: Chris Coffey <[email protected]>
> > ---
> > drivers/staging/most/Makefile | 14 +++++++-------
> > 1 file changed, 7 insertions(+), 7 deletions(-)
>
> I think a patch was sent yesterday to fix these up, did you see it in
> the archives?

I checked the archives before making the patch, and didn't see anything
MOST-related in there for the past few days. The patch below made the
build succeed and generate all of the MOST modules.

>
> thanks,
>
> greg k-h

From 1585293913889522263@xxx Tue Nov 28 07:28:09 +0000 2017
X-GM-THRID: 1585256788780705103
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread