2017-12-07 14:18:29

by Srinivas Kandagatla

Subject: [PATCH] clk: qcom: gcc-msm8996: always enable aggre0_noc gdsc

From: Srinivas Kandagatla <[email protected]>

bus clks which depend on this gdsc are marked as critical,
so this patch flags this gdsc ALWAYS_ON so that bus clks status
does not get stuck at on or off.

Signed-off-by: Srinivas Kandagatla <[email protected]>
---
drivers/clk/qcom/gcc-msm8996.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/qcom/gcc-msm8996.c b/drivers/clk/qcom/gcc-msm8996.c
index 0146d8853488..b2be77469693 100644
--- a/drivers/clk/qcom/gcc-msm8996.c
+++ b/drivers/clk/qcom/gcc-msm8996.c
@@ -3101,7 +3101,7 @@ static struct gdsc aggre0_noc_gdsc = {
.name = "aggre0_noc",
},
.pwrsts = PWRSTS_OFF_ON,
- .flags = VOTABLE,
+ .flags = VOTABLE | ALWAYS_ON,
};

static struct gdsc hlos1_vote_aggre0_noc_gdsc = {
--
2.15.0

2017-12-07 22:54:43

by Stephen Boyd

Subject: Re: [PATCH] clk: qcom: gcc-msm8996: always enable aggre0_noc gdsc

On 12/07, [email protected] wrote:
> From: Srinivas Kandagatla <[email protected]>
>
> bus clks which depend on this gdsc are marked as critical,
> so this patch flags this gdsc ALWAYS_ON so that bus clks status
> does not get stuck at on or off.
>
> Signed-off-by: Srinivas Kandagatla <[email protected]>
> ---
> drivers/clk/qcom/gcc-msm8996.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/gcc-msm8996.c b/drivers/clk/qcom/gcc-msm8996.c
> index 0146d8853488..b2be77469693 100644
> --- a/drivers/clk/qcom/gcc-msm8996.c
> +++ b/drivers/clk/qcom/gcc-msm8996.c
> @@ -3101,7 +3101,7 @@ static struct gdsc aggre0_noc_gdsc = {
> .name = "aggre0_noc",
> },
> .pwrsts = PWRSTS_OFF_ON,
> - .flags = VOTABLE,
> + .flags = VOTABLE | ALWAYS_ON,

I dont think this flag has been added yet. Probably this needs to
be folded into the other series?


--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

2017-12-07 23:30:19

by Srinivas Kandagatla

Subject: Re: [PATCH] clk: qcom: gcc-msm8996: always enable aggre0_noc gdsc

On 07/12/17 22:54, Stephen Boyd wrote:
>> .pwrsts = PWRSTS_OFF_ON,
>> - .flags = VOTABLE,
>> + .flags = VOTABLE | ALWAYS_ON,
> I dont think this flag has been added yet. Probably this needs to
> be folded into the other series?
I agree, I will wait for Rajendras patches to land in or I can request
Rajendra to fold this into his series.




thanks,
srini