From: Colin Ian King <[email protected]>
Pointer esph is being assigned a value that is never read, esph is
re-assigned and only read inside an if statement, hence the
initialization is redundant and can be removed.
Cleans up clang warning:
net/ipv4/esp4.c:657:21: warning: Value stored to 'esph' during
its initialization is never read
Signed-off-by: Colin Ian King <[email protected]>
---
net/ipv4/esp4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/esp4.c b/net/ipv4/esp4.c
index 296d0b956bfe..97689012b357 100644
--- a/net/ipv4/esp4.c
+++ b/net/ipv4/esp4.c
@@ -654,7 +654,7 @@ static void esp_input_restore_header(struct sk_buff *skb)
static void esp_input_set_header(struct sk_buff *skb, __be32 *seqhi)
{
struct xfrm_state *x = xfrm_input_state(skb);
- struct ip_esp_hdr *esph = (struct ip_esp_hdr *)skb->data;
+ struct ip_esp_hdr *esph;
/* For ESN we move the header forward by 4 bytes to
* accomodate the high bits. We will move it back after
--
2.15.1
On Tue, Jan 30, 2018 at 02:53:48PM +0000, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Pointer esph is being assigned a value that is never read, esph is
> re-assigned and only read inside an if statement, hence the
> initialization is redundant and can be removed.
>
> Cleans up clang warning:
> net/ipv4/esp4.c:657:21: warning: Value stored to 'esph' during
> its initialization is never read
>
> Signed-off-by: Colin Ian King <[email protected]>
I've queued this for ipsec-next, will be applied
after the merge window.
On Fri, Feb 02, 2018 at 08:37:50AM +0100, Steffen Klassert wrote:
> On Tue, Jan 30, 2018 at 02:53:48PM +0000, Colin King wrote:
> > From: Colin Ian King <[email protected]>
> >
> > Pointer esph is being assigned a value that is never read, esph is
> > re-assigned and only read inside an if statement, hence the
> > initialization is redundant and can be removed.
> >
> > Cleans up clang warning:
> > net/ipv4/esp4.c:657:21: warning: Value stored to 'esph' during
> > its initialization is never read
> >
> > Signed-off-by: Colin Ian King <[email protected]>
>
> I've queued this for ipsec-next, will be applied
> after the merge window.
Now applied to ipsec-next, thanks!