2018-02-16 19:17:50

by Alexey Dobriyan

Subject: [PATCH] proc: move /proc/sysvipc creation to where it belongs

Signed-off-by: Alexey Dobriyan <[email protected]>
---

fs/proc/root.c | 4 ----
ipc/util.c | 1 +
2 files changed, 1 insertion(+), 4 deletions(-)

--- a/fs/proc/root.c
+++ b/fs/proc/root.c
@@ -136,10 +136,6 @@ void __init proc_root_init(void)
proc_symlink("mounts", NULL, "self/mounts");

proc_net_init();
-
-#ifdef CONFIG_SYSVIPC
- proc_mkdir("sysvipc", NULL);
-#endif
proc_mkdir("fs", NULL);
proc_mkdir("driver", NULL);
proc_create_mount_point("fs/nfsd"); /* somewhere for the nfsd filesystem to be mounted */
--- a/ipc/util.c
+++ b/ipc/util.c
@@ -89,6 +89,7 @@ static int __init ipc_init(void)
{
int err_sem, err_msg;

+ proc_mkdir("sysvipc", NULL);
err_sem = sem_init();
WARN(err_sem, "ipc: sysv sem_init failed: %d\n", err_sem);
err_msg = msg_init();

2018-03-25 16:15:54

by Davidlohr Bueso

Subject: Re: [PATCH] proc: move /proc/sysvipc creation to where it belongs

On Fri, 16 Feb 2018, Alexey Dobriyan wrote:

>Signed-off-by: Alexey Dobriyan <[email protected]>

Acked. However, a small redundant description might be nice.

"
Move the proc_mkdir() call within the sysvipc subsystem such that we avoid
polluting proc_root_init() with petty cpp.
"

Thanks,
Davidlohr