Perf annotate displays function call assembler instructions
with a right arrow. Hitting enter on this line/instruction
causes the browser to disassemble this target function and
show it on the screen.
S390 assembler instruction 'basr %r1,%r2'
jumps to address stored in register 2. Since the
target address is unknown to perf it can not be handled.
Therefore remove the right arrow from such an instruction
as the target function can not be identified.
Signed-off-by: Thomas Richter <[email protected]>
Reviewed-by: Hendrik Brueckner <[email protected]>
---
tools/perf/arch/s390/annotate/instructions.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/perf/arch/s390/annotate/instructions.c b/tools/perf/arch/s390/annotate/instructions.c
index 8c72b44444cb..05f53bd092d4 100644
--- a/tools/perf/arch/s390/annotate/instructions.c
+++ b/tools/perf/arch/s390/annotate/instructions.c
@@ -12,8 +12,7 @@ static struct ins_ops *s390__associate_ins_ops(struct arch *arch, const char *na
ops = &jump_ops;
/* override call/returns */
if (!strcmp(name, "bras") ||
- !strcmp(name, "brasl") ||
- !strcmp(name, "basr"))
+ !strcmp(name, "brasl"))
ops = &call_ops;
if (!strcmp(name, "br"))
ops = &ret_ops;
--
2.14.3
Perf annotate displays function call assembler instructions
with a right arrow. Hitting enter on this line/instruction
causes the browser to disassemble this target function and
show it on the screen. On s390 this results in an error
message 'symbol not found'.
The function call assembly line parsing does not handle
the s390 bras and brasl instructions. Function call__parse
expects the target as first operand:
callq e9140 <__fxstat>
S390 has a register number as first operand:
brasl %r14,41d60 <abort>
Therefore the target addresses on s390 are always zero
which is an invalid address.
Fix this by skipping the first operand on s390.
Signed-off-by: Thomas Richter <[email protected]>
Reviewed-by: Hendrik Brueckner <[email protected]>
---
tools/perf/util/annotate.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 28b233c3dcbe..5a90aa88076d 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -188,7 +188,13 @@ static int call__parse(struct arch *arch, struct ins_operands *ops, struct map *
{
char *endptr, *tok, *name;
- ops->target.addr = strtoull(ops->raw, &endptr, 16);
+ if (!strcmp(arch->name, "s390")) {
+ ops->target.addr = 0;
+ tok = strchr(ops->raw, ',');
+ if (tok)
+ ops->target.addr = strtoull(tok + 1, &endptr, 16);
+ } else
+ ops->target.addr = strtoull(ops->raw, &endptr, 16);
name = strchr(endptr, '<');
if (name == NULL)
--
2.14.3