2018-04-09 12:31:06

by Johannes Thumshirn

Subject: [PATCH v2] qla2xxx: correctly shift host byte

The SCSI host byte has to be shifted by 16 not 6.

As Bart pointed out this patch does not change any functionality
because DID_OK == 0, but a wrong shift is irritating for the reviewer.

Signed-off-by: Johannes Thumshirn <[email protected]>
Reviewed-by: Bart Van Assche <[email protected]>
---
Changes to v1:
* Add Bart's review remark, that I'm not changing actual functionality
as DID_OK == 0

drivers/scsi/qla2xxx/qla_isr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index 89f93ebd819d..49d67e1d571f 100644
--- a/drivers/scsi/qla2xxx/qla_isr.c
+++ b/drivers/scsi/qla2xxx/qla_isr.c
@@ -2368,7 +2368,7 @@ qla25xx_process_bidir_status_iocb(scsi_qla_host_t *vha, void *pkt,
bsg_job->reply_len = sizeof(struct fc_bsg_reply);
/* Always return DID_OK, bsg will send the vendor specific response
* in this case only */
- sp->done(sp, DID_OK << 6);
+ sp->done(sp, DID_OK << 16);

}

--
2.16.2

2018-04-10 01:22:34

by Martin K. Petersen

Subject: Re: [PATCH v2] qla2xxx: correctly shift host byte

Johannes,

> The SCSI host byte has to be shifted by 16 not 6.
>
> As Bart pointed out this patch does not change any functionality
> because DID_OK == 0, but a wrong shift is irritating for the reviewer.

Applied to 4.17/scsi-fixes. Thank you!

--
Martin K. Petersen Oracle Linux Engineering